Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags/change namespace in scripting #2951

Open
soulgalore opened this issue Apr 6, 2020 · 0 comments
Open

Add tags/change namespace in scripting #2951

soulgalore opened this issue Apr 6, 2020 · 0 comments

Comments

@soulgalore
Copy link
Member

A really powerful feature would be to set the namespace of a test in a script dynamically and add tags per test as proposed in #2512. I think they should be implemented the same time because it could probably be a generic thing.

The tags and namespace needs to be passed around in the messages in the queue (it could be some extra fields), that way Graphite/InfluxDb can override the default settings easily.

One way to implement it would be to add more meta data about a test https://www.sitespeed.io/documentation/sitespeed.io/scripting/#meta-data

We could add a "tag" feature or just key/value, then sitedpeed.io could pickup those extra meta data and pass them on in the messages. I'm not 100% sure yet how it should work, but I think that would be a way forward.

It would make scripting super generic and also make it possible to add annotations from scripting, so you could send a specific annotation depending on what happens in the script.

But lets add one thing at a time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant