api: Update Subscription for API changes

Remove `emailAddress` field per update in FL 226. Rename
`canRemoveSubscribersGroupId`. Also change `isWebPublic`
to be non-null. It has been a field on subscriptions
since at least FL 8 (see zulip/zulip@f93c19ec6 in
`zerver/openapi/zulip.yaml` and the docs attached to
`Subscription.API_FIELDS` in `zerver/models.py`).

Author: sirpengi

lib/api/model/model.dart

@@ -326,16 +326,18 @@ class Subscription {
   final int? streamWeeklyTraffic;
 
   final bool inviteOnly;
-  final bool? isWebPublic; // TODO(server-??): doc doesn't say when added
+  final bool isWebPublic;
   final bool historyPublicToSubscribers;
   final int? messageRetentionDays;
   // final List<int> subscribers; // we register with includeSubscribers false
 
   final StreamPostPolicy streamPostPolicy;
   // final bool? isAnnouncementOnly; // deprecated for `streamPostPolicy`; ignore
-  final String emailAddress;
 
-  final int? canRemoveSubscribersGroupId; // TODO(server-6)
+  // TODO(server-6): `canRemoveSubscribersGroupId` added in FL 142
+  // TODO(server-8): in FL 197 renamed to `canRemoveSubscribersGroup`
+  @JsonKey(readValue: _readCanRemoveSubscribersGroup)
+  final int? canRemoveSubscribersGroup;
 
   // Then, fields that are specific to the subscription,
   // i.e. the user's relationship to the stream.
@@ -353,6 +355,10 @@ class Subscription {
 
   final String color;
 
+  static int? _readCanRemoveSubscribersGroup(Map json, String key) {
+    return json[key] ?? json['can_remove_subscribers_group_id'];
+  }
+
   Subscription({
     required this.streamId,
     required this.name,
@@ -366,7 +372,6 @@ class Subscription {
     required this.pushNotifications,
     required this.audibleNotifications,
     required this.pinToTop,
-    required this.emailAddress,
     required this.isMuted,
     required this.isWebPublic,
     required this.color,
@@ -375,7 +380,7 @@ class Subscription {
     required this.historyPublicToSubscribers,
     required this.firstMessageId,
     required this.streamWeeklyTraffic,
-    required this.canRemoveSubscribersGroupId,
+    required this.canRemoveSubscribersGroup,
   });
 
   factory Subscription.fromJson(Map<String, dynamic> json) =>