Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create new discussions during development. #3

Open
givanse opened this issue Mar 30, 2015 · 3 comments
Open

Don't create new discussions during development. #3

givanse opened this issue Mar 30, 2015 · 3 comments

Comments

@givanse
Copy link

givanse commented Mar 30, 2015

While testing the app, new discussions will be added. The Disqus links will be of the form:

http://localhost:4200/discussion-identifier

Wire up Disqus only in production mode.

@sir-dunxalot
Copy link
Owner

I like the idea. Perhaps it should be done in the form of an overwriteable config setting incase people want to test their Disqus settings locally. For example:

/* jshint node: true */

module.exports = function(environment) {
  var ENV = {
  }

  if (environment === 'development') {
    Disqus.enabled = true;
  }

  return ENV;
};

@sir-dunxalot
Copy link
Owner

I don't have any spare time this week but I'd happily accept a PR for this. Otherwise, I will try my best to get to it within the next 10-14 days.

@givanse
Copy link
Author

givanse commented Mar 31, 2015

I'm on the same boat, I'll let you know if I start to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants