Merge pull request #36 from A-dead-pixel/zombies-PR

Wolf480pl · web-flow · commit 676c4c355bf2 · 2023-06-09T19:29:04.000+02:00
Reap leftover zombie processes
diff --git a/src/executor/Executor.cc b/src/executor/Executor.cc
@@ -190,6 +190,9 @@ void Executor::executeParent() {
     for (auto& listener: eventListeners_) {
         listener->onPostExecute();
     }
+    // This is needed, as most earlier waits have the WNOWAIT flag.
+    withErrnoCheck(
+            "final waitpid failed: ", {ECHILD}, waitpid, -1, nullptr, WNOHANG);
 }
 
 void Executor::setupSignalHandling() {

Original file line number	Diff line number	Diff line change
`@@ -190,6 +190,9 @@ void Executor::executeParent() {`
`190`	`190`	`for (auto& listener: eventListeners_) {`
`191`	`191`	`listener->onPostExecute();`
`192`	`192`	`}`
	`193`	`+ // This is needed, as most earlier waits have the WNOWAIT flag.`
	`194`	`+ withErrnoCheck(`
	`195`	`+ "final waitpid failed: ", {ECHILD}, waitpid, -1, nullptr, WNOHANG);`
`193`	`196`	`}`
`194`	`197`
`195`	`198`	`void Executor::setupSignalHandling() {`