fix: Handle IP address absence

Author: osbre

src/TrackingPolicy.php

@@ -6,24 +6,31 @@ class TrackingPolicy
 {
     public function shouldCollectAnalytics(): bool
     {
-        if ($this->clientIpExcluded($_SERVER['HTTP_X_FORWARDED_FOR'] ?? $_SERVER['REMOTE_ADDR'])) {
+        if ($this->isClientIpExcluded()) {
             return false;
         }
 
         if (! is_user_logged_in()) {
             return true;
         }
 
-        return ! $this->containsExcludedRole(wp_get_current_user()->roles);
+        return ! $this->containsExcludedRole();
     }
 
-    protected function clientIpExcluded(string $ip): bool
+    protected function isClientIpExcluded(): bool
     {
+        $ip = $_SERVER['HTTP_X_FORWARDED_FOR'] ?? $_SERVER['REMOTE_ADDR'];
+
+        if (empty($ip)) return false;
+
         return in_array($ip, Setting::array(SettingName::EXCLUDED_IP_ADDRESSES));
     }
 
-    protected function containsExcludedRole(array $roles): bool
+    protected function containsExcludedRole(): bool
     {
-        return array_intersect(Setting::array(SettingName::EXCLUDED_ROLES), $roles) !== [];
+        $currentRoles = wp_get_current_user()->roles;
+        $excludedRoles = Setting::array(SettingName::EXCLUDED_ROLES);
+
+        return array_intersect($excludedRoles, $currentRoles) !== [];
     }
 }