wip

Author: osbre

.github/workflows/tests.yml

@@ -87,6 +87,9 @@ jobs:
                       --path=wordpress \
                       --skip-email \
                       --allow-root
+                    wp user create author author@localhost --role=author --user_pass=author
+                    wp user create editor editor@localhost --role=editor --user_pass=editor
+                    wp user create subscriber subscriber@localhost --role=subscriber --user_pass=subscriber
 
             -   name: Show current config values
                 run: wp config list --path=wordpress --allow-root

tests/Browser/PluginSettingsTest.php

@@ -2,7 +2,7 @@
 
 namespace Tests\Browser;
 
-use function Tests\asAdmin;
+use function Tests\{asAdmin, asAuthor, asEditor};
 
 const SA_ADMIN_NOTICE = '<!-- Simple Analytics: Not logging requests from admins -->';
 const SA_DEFAULT_SCRIPT = 'src="https://scripts.simpleanalyticscdn.com/latest.js"></script>';
@@ -20,13 +20,13 @@
 
 it('adds a script by default', function () {
     $homePage = visit('http://localhost:8100');
-    expect($homePage->content())->dump()->toContain(SA_DEFAULT_SCRIPT);
+    expect($homePage->content())->toContain(SA_DEFAULT_SCRIPT);
 });
 
-it('adds a comment when an authenticated user visits', function () {
+it('adds inactive script for authenticated users by default', function () {
     $homePage = asAdmin()->navigate('http://localhost:8100');
 
-    expect($homePage->content())->dump()
+    expect($homePage->content())
         ->toContain(SA_ADMIN_NOTICE)
         ->toContain(SA_INACTIVE_ADMIN_SCRIPT);
 });
@@ -52,3 +52,21 @@
 
     expect(visit('http://localhost:8100')->content())->toContain('data-ignore-pages="/vouchers"');
 });
+
+it('adds inactive script for selected user roles', function () {
+    asAdmin()
+        ->navigate('http://localhost:8100/wp-admin/options-general.php?page=simpleanalytics&tab=ignore-rules')
+        ->check('simpleanalytics_exclude_user_roles-editor')
+        ->check('simpleanalytics_exclude_user_roles-author')
+        ->click('Save Changes')
+        ->assertChecked('simpleanalytics_exclude_user_roles-editor')
+        ->assertChecked('simpleanalytics_exclude_user_roles-author');
+
+    expect(asEditor()->navigate('http://localhost:8100')->content())
+        ->toContain(SA_ADMIN_NOTICE)
+        ->toContain(SA_INACTIVE_ADMIN_SCRIPT);
+
+    expect(asAuthor()->navigate('http://localhost:8100')->content())
+        ->toContain(SA_ADMIN_NOTICE)
+        ->toContain(SA_INACTIVE_ADMIN_SCRIPT);
+});

tests/Pest.php

@@ -13,6 +13,8 @@
 |
 */
 
+use Pest\Browser\Api\Webpage;
+
 pest()->extend(TestCase::class)->in('Feature');
 
 /*
@@ -41,11 +43,26 @@
 |
 */
 
-function asAdmin()
+function asUser(string $login, string $password): Webpage
 {
     return visit('http://localhost:8100/wp-admin')
-        ->fill('user_login', 'admin')
-        ->fill('user_pass', 'admin')
+        ->fill('user_login', $login)
+        ->fill('user_pass', $password)
         ->press('wp-submit')
         ->assertUrlIs('http://localhost:8100/wp-admin');
 }
+
+function asAdmin()
+{
+    return asUser('admin', 'admin');
+}
+
+function asAuthor()
+{
+    return asUser('author', 'author');
+}
+
+function asEditor()
+{
+    return asUser('editor', 'editor');
+}