Fix default boolean option bug

osbre · adriaandotcom · commit 2ea77482036b · 2024-09-13T18:15:37.000+02:00
diff --git a/src/Setting.php b/src/Setting.php
@@ -22,7 +22,7 @@ public static function boolean(string $key, ?bool $default = null): ?bool
     {
         $value = get_option($key);
 
-        if (empty($value)) {
+        if ($value === null || $value === '') {
             return $default;
         }
 
diff --git a/src/TrackingPolicy.php b/src/TrackingPolicy.php
@@ -23,7 +23,7 @@ public function shouldCollectAnalytics(): bool
 
     protected function clientIpExcluded(string $ip): bool
     {
-        return in_array($ip, Setting::array(SettingName::EXCLUDED_IP_ADDRESSES), true);
+        return in_array($ip, Setting::array(SettingName::EXCLUDED_IP_ADDRESSES));
     }
 
     protected function containsExcludedRole(array $roles): bool

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ public static function boolean(string $key, ?bool $default = null): ?bool`
`22`	`22`	`{`
`23`	`23`	`$value = get_option($key);`
`24`	`24`
`25`		`- if (empty($value)) {`
	`25`	`+ if ($value === null \|\| $value === '') {`
`26`	`26`	`return $default;`
`27`	`27`	`}`
`28`	`28`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ public function shouldCollectAnalytics(): bool`
`23`	`23`
`24`	`24`	`protected function clientIpExcluded(string $ip): bool`
`25`	`25`	`{`
`26`		`- return in_array($ip, Setting::array(SettingName::EXCLUDED_IP_ADDRESSES), true);`
	`26`	`+ return in_array($ip, Setting::array(SettingName::EXCLUDED_IP_ADDRESSES));`
`27`	`27`	`}`
`28`	`28`
`29`	`29`	`protected function containsExcludedRole(array $roles): bool`