fix: use activatePluginIfNeeded in first test to prevent failures when plugin already active

adriaandotcom · adriaandotcom · commit 2d566f0b68f6 · 2025-11-28T15:52:54.000+07:00
diff --git a/tests/Browser/PluginSettingsTest.php b/tests/Browser/PluginSettingsTest.php
@@ -6,8 +6,10 @@ class PluginSettingsTest extends BrowserTestCase
 {
     public function test_activation_and_presence_of_default_scripts(): void
     {
-        $this->asAdmin()->visit('/wp-admin/plugins.php')
-            ->click('#activate-simpleanalytics')
+        $browser = $this->asAdmin();
+        $this->activatePluginIfNeeded($browser);
+
+        $browser->visit('/wp-admin/plugins.php')
             ->assertSeeElement('#deactivate-simpleanalytics')
             ->visit('/')
             ->assertContains('<!-- Simple Analytics: Not logging requests from admins -->')

Original file line number	Diff line number	Diff line change
`@@ -6,8 +6,10 @@ class PluginSettingsTest extends BrowserTestCase`
`6`	`6`	`{`
`7`	`7`	`public function test_activation_and_presence_of_default_scripts(): void`
`8`	`8`	`{`
`9`		`- $this->asAdmin()->visit('/wp-admin/plugins.php')`
`10`		`- ->click('#activate-simpleanalytics')`
	`9`	`+ $browser = $this->asAdmin();`
	`10`	`+ $this->activatePluginIfNeeded($browser);`
	`11`	`+`
	`12`	`+ $browser->visit('/wp-admin/plugins.php')`
`11`	`13`	`->assertSeeElement('#deactivate-simpleanalytics')`
`12`	`14`	`->visit('/')`
`13`	`15`	`->assertContains('<!-- Simple Analytics: Not logging requests from admins -->')`