Merge branch 'v12' into codex/skip-automated-events-for-data-simple-event-elements

Author: adriaandotcom

.eslintrc.js

@@ -12,7 +12,13 @@ module.exports = {
     SharedArrayBuffer: "readonly",
   },
   parserOptions: {
-    ecmaVersion: 2018,
+    ecmaVersion: 2020,
   },
+  overrides: [
+    {
+      files: ["test/**/*.js"],
+      env: { mocha: true },
+    },
+  ],
   rules: {},
 };

.github/workflows/testing.yml

@@ -1,29 +1,28 @@
 name: Browserstack
 
 on:
+  workflow_dispatch:
   pull_request:
     types: [opened, synchronize]
   push:
     branches:
       - main
-  workflow_dispatch:
+
+env:
+  NODE_VERSION: 22.16
 
 jobs:
   linting:
     runs-on: ubuntu-latest
     if: github.event_name == 'pull_request'
 
-    strategy:
-      matrix:
-        node-version: [22.16]
-
     steps:
       - uses: actions/checkout@v4
 
-      - name: Use Node.js ${{ matrix.node-version }}
+      - name: Use Node.js ${{ env.NODE_VERSION }}
         uses: actions/setup-node@v4
         with:
-          node-version: ${{ matrix.node-version }}
+          node-version: ${{ env.NODE_VERSION }}
 
       - name: Run npm ci
         run: npm ci
@@ -39,17 +38,13 @@ jobs:
   unit-tests:
     runs-on: ubuntu-latest
 
-    strategy:
-      matrix:
-        node-version: [22.16]
-
     steps:
       - uses: actions/checkout@v4
 
-      - name: Use Node.js ${{ matrix.node-version }}
+      - name: Use Node.js ${{ env.NODE_VERSION }}
         uses: actions/setup-node@v4
         with:
-          node-version: ${{ matrix.node-version }}
+          node-version: ${{ env.NODE_VERSION }}
 
       - name: Run npm ci
         run: npm ci
@@ -63,14 +58,37 @@ jobs:
           CI: true
           NODE_ENV: test
 
-  browserstack:
+  build:
     runs-on: ubuntu-latest
-    needs: [unit-tests, linting]
+    needs: unit-tests
     if: (github.event_name == 'push' && github.ref == 'refs/heads/main') || github.event_name == 'workflow_dispatch'
 
-    strategy:
-      matrix:
-        node-version: [22.16]
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Use Node.js ${{ env.NODE_VERSION }}
+        uses: actions/setup-node@v4
+        with:
+          node-version: ${{ env.NODE_VERSION }}
+
+      - name: Run npm ci
+        run: npm ci
+
+      - name: Build project
+        run: npm run build
+
+      - name: Commit build changes
+        run: |
+          git config --local user.email "[email protected]"
+          git config --local user.name "GitHub Action"
+          git add dist/
+          git diff --staged --quiet || git commit -m "Update build artifacts [skip ci]"
+          git push
+
+  browserstack:
+    runs-on: ubuntu-latest
+    needs: [unit-tests, linting, build]
+    if: (github.event_name == 'push' && github.ref == 'refs/heads/main') || github.event_name == 'workflow_dispatch'
 
     steps:
       - name: "BrowserStack Env Setup"
@@ -88,10 +106,10 @@ jobs:
 
       - uses: actions/checkout@v4
 
-      - name: Use Node.js ${{ matrix.node-version }}
+      - name: Use Node.js ${{ env.NODE_VERSION }}
         uses: actions/setup-node@v4
         with:
-          node-version: ${{ matrix.node-version }}
+          node-version: ${{ env.NODE_VERSION }}
 
       - name: Run npm ci
         run: npm ci

dist/latest/auto-events.js.map

@@ -165,6 +165,7 @@
         }).length === 0
       );
       /** else **/
+      // eslint-disable-next-line no-unreachable
       return true;
       /** endif **/
     };
@@ -253,6 +254,7 @@
             if (ignore && !allowParams.length) return falseVar;
             /** else **/
             if (ignore) return falseVar;
+            // eslint-disable-next-line no-redeclare
             var regex =
               "^((utm_)" +
               (strictUtm ? "" : "?") +
@@ -498,6 +500,7 @@
       isBotAgent ||
       Math.random() == Math.random();
     /** else **/
+    // eslint-disable-next-line no-redeclare
     var bot = isBotAgent;
     /** endif **/
 

src/default.js

@@ -1,5 +1,4 @@
 const crypto = require("crypto");
-const { networkInterfaces: getNetworkInterfaces } = require("os");
 const { DEBUG, SERVER_PORT } = require("../constants");
 const { promisify } = require("util");
 const { By, Key } = require("selenium-webdriver");

test/helpers/index.js

@@ -1,7 +1,7 @@
 const url = require("url");
 const http = require("http");
 const { readFileSync } = require("fs");
-const { SERVER_PORT, DEBUG, CI } = require("../constants");
+const { SERVER_PORT, DEBUG } = require("../constants");
 const { getJSONBody } = require("./request");
 
 const log = (...messages) =>

test/helpers/server.js

@@ -267,12 +267,14 @@ const getDeviceName = ({
     if (nextDriver) {
       log(`Reusing next driver...`);
       driver = await nextDriver;
+      // eslint-disable-next-line require-atomic-updates
       nextDriver = null;
     } else {
       log(`Waiting to get ${browser.name}...`);
       driver = await getDriverWithTimeout(browser);
     }
 
+    // eslint-disable-next-line require-atomic-updates
     nextDriver = backgroundDriver;
 
     // Try again with new device when driver is not available
@@ -328,8 +330,6 @@ const getDeviceName = ({
     // Empty global REQUESTS
     global.REQUESTS = [];
 
-    let errorMessage = null;
-
     try {
       await navigate({
         ...browser,
@@ -383,9 +383,6 @@ const getDeviceName = ({
       });
 
       await require("./test-events")(browser);
-    } catch (error) {
-      errorMessage = error.message;
-      throw error;
     } finally {
       // if (!driver) return;
       // try {