Skip to content

Commit 676ea16

Browse files
committed
new deprecations fix
1 parent 402ae85 commit 676ea16

File tree

7 files changed

+14
-12
lines changed

7 files changed

+14
-12
lines changed

src/Controller/Webhook/AddListener.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,6 @@ public function handle(ServerRequestInterface $request): ResponseInterface
3232
throw new ApiException('Webhook: \''.$params->listeningUrl.'\' with type: \''.$type.'\' already exist', HttpCodes::HTTP_CONFLICT);
3333
}
3434

35-
return ResponseFactory::makeJson($webhook, new WebhookTransformer());
35+
return ResponseFactory::makeObject($webhook, new WebhookTransformer());
3636
}
3737
}

src/Controller/Webhook/RemoveListener.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,6 @@ public function handle(ServerRequestInterface $request): ResponseInterface
2424

2525
$this->repository->delete($webhookId);
2626

27-
return ResponseFactory::makeJson(null);
27+
return ResponseFactory::makeObject(null);
2828
}
2929
}

src/Controller/Webhook/Symfony.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ public function addListener(Request $request): Response
3030
throw new ConflictHttpException('Webhook: \''.$params->listeningUrl.'\' with type: \''.$type.'\' already exist');
3131
}
3232

33-
return ResponseFactory::makeJson($webhook, new WebhookTransformer());
33+
return ResponseFactory::makeObject($webhook, new WebhookTransformer());
3434
}
3535

3636
public function removeListener(Request $request): Response
@@ -39,6 +39,6 @@ public function removeListener(Request $request): Response
3939

4040
$this->repository->delete($webhookId);
4141

42-
return ResponseFactory::makeJson(null);
42+
return ResponseFactory::makeObject(null);
4343
}
4444
}

src/Factory/Server/ResponseFactory.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ public static function makeJson(mixed $body, ?Transformer $transformer = null, i
6060
*/
6161
public static function makeArray(\Iterator $body, ?Transformer $transformer = null, int $code = HttpCodes::HTTP_OK, array $headers = []): ResponseInterface
6262
{
63+
/** @phpstan-ignore-next-line */
6364
return self::makeJsonStream($body, $transformer, $code, $headers);
6465
}
6566

src/Factory/Symfony/ResponseFactory.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ public static function makeJson(mixed $body, ?Transformer $transformer = null, i
5050
*/
5151
public static function makeArray(iterable $body, ?Transformer $transformer = null, int $code = HttpCodes::HTTP_OK, array $headers = []): StreamedResponse
5252
{
53+
/** @phpstan-ignore-next-line */
5354
return self::makeJsonStream($body, $transformer, $code, $headers);
5455
}
5556

test/Factory/Server/ResponseFactoryTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,21 +8,21 @@
88
final class ResponseFactoryTest extends TestCase
99
{
1010
/**
11-
* @dataProvider dataProviderMakeJsonStream
11+
* @dataProvider dataProviderMakeArray
1212
*
1313
* @param array<mixed> $streamedData
1414
*/
15-
public function testMakeJsonStream(string $expectedBody, array $streamedData): void
15+
public function testMakeArray(string $expectedBody, array $streamedData): void
1616
{
17-
$response = ResponseFactory::makeJsonStream(new \ArrayIterator($streamedData));
17+
$response = ResponseFactory::makeArray(new \ArrayIterator($streamedData));
1818

1919
self::assertSame($expectedBody, $response->getBody()->getContents());
2020
}
2121

2222
/**
2323
* @return array<array<mixed>>
2424
*/
25-
public static function dataProviderMakeJsonStream(): array
25+
public static function dataProviderMakeArray(): array
2626
{
2727
return [
2828
['[548846,"sadasjkfghjsg"]', [548846, 'sadasjkfghjsg']],

test/Factory/Symfony/ResponseFactoryTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,13 @@
1010
final class ResponseFactoryTest extends TestCase
1111
{
1212
/**
13-
* @dataProvider dataProviderMakeJsonStream
13+
* @dataProvider dataProviderMakeArray
1414
*
1515
* @param iterable<mixed> $streamedData
1616
*/
17-
public function testMakeJsonStream(string $expectedBody, iterable $streamedData): void
17+
public function testMakeArray(string $expectedBody, iterable $streamedData): void
1818
{
19-
$response = ResponseFactory::makeJsonStream($streamedData);
19+
$response = ResponseFactory::makeArray($streamedData);
2020

2121
ob_start();
2222
$response->sendContent();
@@ -28,7 +28,7 @@ public function testMakeJsonStream(string $expectedBody, iterable $streamedData)
2828
/**
2929
* @return array<array<mixed>>
3030
*/
31-
public static function dataProviderMakeJsonStream(): array
31+
public static function dataProviderMakeArray(): array
3232
{
3333
return [
3434
['[548846,"sadasjkfghjsg"]', [548846, 'sadasjkfghjsg']],

0 commit comments

Comments
 (0)