Server\ExceptionTransformer debug message readability improvement and file trace added

Author: Triplkrypl

src/Service/Server/ExceptionTransformer.php

@@ -27,7 +27,8 @@ public function toApi($transformed): \stdClass
         $responseData = new \stdClass();
         $responseData->message = 'Internal server error';
         if ($this->configRepository->getServerConfig()->debug()) {
-            $responseData->message = 'Exception ('.\get_class($transformed).') message: "'.$transformed->getMessage().'" from: "'.$transformed->getFile().'":'.$transformed->getLine();
+            $responseData->message = 'Exception ('.\get_class($transformed).') message: \''.$transformed->getMessage().'\' from: '.$transformed->getFile().':'.$transformed->getLine();
+            $responseData->trace = array_map(fn (array $item): string => ($item['file'] ?? '-').':'.($item['line'] ?? '-'), $transformed->getTrace());
         }
 
         return $responseData;

test/Service/Server/ExceptionTransformerTest.php

@@ -0,0 +1,49 @@
+<?php
+
+declare(strict_types=1);
+
+use PHPUnit\Framework\TestCase;
+use SimpleAsFuck\ApiToolkit\Service\Server\ExceptionTransformer;
+
+/**
+ * @covers \SimpleAsFuck\ApiToolkit\Service\Server\ExceptionTransformer
+ */
+final class ExceptionTransformerTest extends TestCase
+{
+    /**
+     * @dataProvider dataProviderToApi
+     */
+    public function testToApi(string $expectedMessage, bool $debug): void
+    {
+        $config = $this->createMock(SimpleAsFuck\ApiToolkit\Service\Config\Repository::class);
+        $config->method('getServerConfig')->willReturn(new \SimpleAsFuck\ApiToolkit\Model\Server\Config($debug));
+
+        $transformer = new ExceptionTransformer($config);
+
+        $exception = new \Exception('Test');
+
+        $transformedData = $transformer->toApi($exception);
+
+        self::assertSame($expectedMessage, $transformedData->message);
+        if ($debug) {
+            self::assertIsArray($transformedData->trace);
+            foreach ($transformedData->trace as $item) {
+                self::assertIsString($item);
+                self::assertNotSame('', $item);
+            }
+        } else {
+            self::assertObjectNotHasAttribute('trace', $transformedData);
+        }
+    }
+
+    /**
+     * @return array<array<mixed>>
+     */
+    public function dataProviderToApi(): array
+    {
+        return [
+            ['Internal server error', false],
+            ['Exception (Exception) message: \'Test\' from: '.__DIR__.'/ExceptionTransformerTest.php:23', true],
+        ];
+    }
+}