Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate auroras TTFZ - use mt_metadata.TF instead #203

Open
2 tasks
kkappler opened this issue Aug 6, 2022 · 2 comments
Open
2 tasks

Deprecate auroras TTFZ - use mt_metadata.TF instead #203

kkappler opened this issue Aug 6, 2022 · 2 comments

Comments

@kkappler
Copy link
Collaborator

kkappler commented Aug 6, 2022

This is not trivial because many tests use the TTFZ for validation.

TTFZ is used for apparent_resistivity calculations which are cited in tests.
So we need

  • An apparent resistivity calculator that interfaces with transfer function as a standalone method
  • TTFZ extends aurora/transfer_function.base.TransferFunction so we would need to add the mt_metadata there as well

This is a pretty tricky task. Probably best to start by making TransferFunction base use mt_metadata.TF first.
There is a lot of duplication between auroras TransferFunction base and mt_metadata TF.

One way to do this would be to start by

  • adding a to_mt_metadata() method to TransferFunction base
  • store a copy of the mt_metadata object in TransferFunction
  • then after the arrays are initialized, call to_mt_metadata() so that the self.mt_metadata_tf is updated
  • then, update both the original arrays (to keep tests passing) and set self.mt_metadata_tf whenever the tf value is set or updated.
  • Then replace self.tf with something that references the mt_metadata object
  • By that point, the mt_metadata object is doing everything, and the arrays are only used for setting values
  • Then try removing the setting of the original arrays and see of tests still pass
@kkappler
Copy link
Collaborator Author

kkappler commented Aug 30, 2023

  • A Along the way, we should simplify the way that metadata is passed to the TF object. Will create a branch to attempt to pack the survey_metadata into the KernelDataset, during initialize_dataframe_for_processing.

kkappler added a commit that referenced this issue Aug 30, 2023
Modify KernelDataset so that it keeps a copy of survey metadata
This survey metadata is still not being filed correctly in the
TF object however.
@kkappler
Copy link
Collaborator Author

Apparent resistivity does not exist in mt_metadata. The aurora method should move to sandbox until we are integrated with MTPy

kkappler added a commit that referenced this issue Jul 20, 2024
- see #203. It will be easier to initialize an mt_metadata TF to replace this
class rather than create a new version of TF
@kkappler kkappler changed the title Deprecate auroras TTFZ.apparent_resistivity method - use mt_metadata.TF instead Deprecate auroras TTFZ - use mt_metadata.TF instead Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant