Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media with early colons is counted as URL protocol #1161

Open
Minion3665 opened this issue Nov 20, 2024 · 0 comments
Open

Media with early colons is counted as URL protocol #1161

Minion3665 opened this issue Nov 20, 2024 · 0 comments

Comments

@Minion3665
Copy link

Bug description

I am using johnny.decimal to name pages, except I foolishly decided that colons look better than blank spaces so I end up with page names like S01: Skyler Grey/40-49: Travel/41: Leisure/S01.41+2024-10: USA trip

Fine, great, pages work fine... except when uploading images. If I drag and drop an image into the page, it doesn't display at all, like this:

Enregistrement d'écran_20241120_115658.webm
(as demonstrated you can refresh the page/etc. with no change)

If you remove the exclamation mark and try to click on the URL, you instead get a dialog asking you if you want to let your silverbullet instance open the page with a handler for the "protocol" before the colon ('scuse my French, this says "Allow https://silverbullet.starrysky.fyi to open this s01 URL with system handler")
image

As a workaround, you can add ./ to the front of the URL, although this does make the URL display as if it doesn't exist:
Enregistrement d'écran_20241120_120402.webm

You can also get away with this if you have a slash in the URL before the colon. For example, if the space were called Skyler Grey/S01: Personal instead this doesn't occur

Reproduction steps

  • Call a page S01: Foo/Bar. This has to be at the top of your workspace (you can't have Baz/S01: Foo/Bar)
  • Drag and drop an image onto the page

Actual outcome

  • The image isn't displayed

Expected outcome

  • The image should be displayed even if the first part of the page name contains a colon

Versions

Silverbullet Version: Occurs on both 0.9.4 and 0.10.1
Browser Version: Occurs on both Firefox 132.0.1 and Chromium 130.0.6723.116
Sync or online mode: Occurs on both

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant