-
Notifications
You must be signed in to change notification settings - Fork 2
/
Copy pathChangeLog
1519 lines (1050 loc) · 53 KB
/
ChangeLog
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
commit 11c0e70b946ca661eea53c446cd3b8583bab8bfa
Author: Dan Kenigsberg <[email protected]>
Date: Tue Jun 17 10:51:30 2014 +0100
sudoers: fix path to ovirt-shutdown-wrappers.sh
Thanks to John Xue for reporting the issue.
Change-Id: I6964e654cff6e0c602ff87ee5502fac2d9db7705
Signed-off-by: Dan Kenigsberg <[email protected]>
commit 000580fbc36360af370021e35880b6f53a120fcb
Author: Lev Veyde <[email protected]>
Date: Mon Jun 16 13:05:43 2014 +0300
Fix win-guest-agent-build-exe.bat
File paths must use backslashes.
Change-Id: I24609f3afccd364ba2717e57cf241711f2461c91
Signed-off-by: Lev Veyde <[email protected]>
commit bea77cdfe1f2ada3fba8c66c8864cb420f229709
Author: Vinzenz Feenstra <[email protected]>
Date: Thu May 29 08:58:03 2014 +0200
Speed up screenlocking on systems with logind
Since logind is able to handle the screen locking, we're now prefering
to use it, since it is handling the locking much more simple and reliable
than our attempts to support multiple desktop environments.
Change-Id: Iaaf01e5c6c612178f207e3acfc877d30e0a09ec8
Bug-Url: https://bugzilla.redhat.com/1097390
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit 0f5e43fd823d49563d31eb697c173038c2638e2d
Author: Vinzenz Feenstra <[email protected]>
Date: Tue Jun 10 12:40:01 2014 +0200
win32: Also report 64-Bit applications Win-x64
Up until now we did not report entries from the 64-Bit view of the
registry. This commit reports those entries and also deduplicates the
entries.
Change-Id: I99e08710257331f5dce36ca64653de6f88139592
Bug-Url: https://bugzilla.redhat.com/1105056
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit 264a0f8fd54117c38b33a6c201bb549ff12cb1a2
Author: Vinzenz Feenstra <[email protected]>
Date: Thu Jun 5 14:56:09 2014 +0200
Cleanup the getApplications code
Change-Id: Iceb493bb6b6703e426606febb0cdbce9a8890953
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit 6666b1d9c82ba6fdaa27bc4300d1d223bf487063
Author: Vinzenz Feenstra <[email protected]>
Date: Tue Jun 3 12:19:06 2014 +0200
No output when guest agent already running or stopped on RHEL5/6
When the guest agent is already running and 'service ovirt-guest-agent start'
is executed it no longer prints anything.
The same for 'service ovirt-guest-agent stop' when the agent is already
stopped.
Additionally restart will use the same behaviour
Change-Id: Id27e5b9f91b675fb5f2d2be8d5d1663efd34293f
Bug-Url: https://bugzilla.redhat.com/1028381
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit 41761f0a6676cf03ed5157842e95fc8827c03e7f
Author: Vinzenz Feenstra <[email protected]>
Date: Mon Jun 2 16:23:54 2014 +0200
Filter Windows HotFixes by ReleaseType value
Non-english releases contain a field 'ReleaseType' which contains
an english string 'Security Update', 'Hotfix' or 'Update'
Additionally we're checking for 'ParentKeyName' which contains
'OperatingSystem' in case of an update.
Change-Id: I4ab40ed538a48d79f30ee300d791ce4636371634
Bug-Url: https://bugzilla.redhat.com/1103710
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit 8e9f7f50dde29150cb93a7d308a84e41a020c8c1
Author: Vinzenz Feenstra <[email protected]>
Date: Thu May 29 11:26:19 2014 +0200
Report FQDN more periodically
Change-Id: I6754a6d77226636b8753425ca75cb7ccd56aa093
Bug-Url: https://bugzilla.redhat.com/1101947
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit e48aab60028e59188ac1b1fe1c02651c3b14a329
Author: Vinzenz Feenstra <[email protected]>
Date: Wed May 28 16:14:02 2014 +0200
Fix SSO on RHEL6
The new pam implementation needs the ask_secret to be answered as well.
Change-Id: I21f5da545d4fa26f816c4e25c88eccb09d4cfd56
Bug-Url: https://bugzilla.redhat.com/1102095
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit 3bf47a823485e828519514129cad62f2bdfb5850
Author: Vinzenz Feenstra <[email protected]>
Date: Fri May 23 09:58:26 2014 +0200
Implement default configuration values
When adding new config values to the configuration files, it's possible
that due to the installation the configuration files won't get updated,
when they are modified by an user/administrator on that given system.
By using defaults, we can override this problem and ensure a proper
application start, when config values are missing which are mandatory,
to the functionality.
Change-Id: I5ce9d457e826448aad205ce4abda5dc4b0210804
Signed-off-by: Vinzenz Feenstra <[email protected]>
Bug-Url: https://bugzilla.redhat.com/1100249
commit 3f26e26c3b5209e5c4f62ceb1e37ba170869e489
Author: Vinzenz Feenstra <[email protected]>
Date: Thu May 22 16:16:56 2014 +0200
Fixing pep8 errors
Change-Id: Ic7c9c31493926deb7ae4f11a0f0bc487b04a7365
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit 1431b7a5c07b98a586fb3376dfe22d02f5a51782
Author: Vinzenz Feenstra <[email protected]>
Date: Fri Apr 25 11:45:30 2014 +0200
packaging: Include python unit test files
Change-Id: I65b246a05192d5898e2e122b8c90cf1a7160b50b
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit ac2926fce74246d7512a1322c9cb510007a1602a
Author: Vinzenz Feenstra <[email protected]>
Date: Tue Apr 29 16:24:31 2014 +0200
agent: Report Windows fake cached/buffers memory entries
To unifiy the OS report structure this has to be reported
for Windows as well.
Change-Id: Id71a250084aa6a5efc9583f757accdde772128be
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit 169b01871c264560bb93ca49a41e62d3681c1ad9
Author: Amador Pahim <[email protected]>
Date: Mon Apr 28 10:34:13 2014 -0300
agent: report Linux cached/buffers memory
Some applications, like Oracle Directory Server, use cached memory
and never release it. Users need to take this memory into account
when planning the memory requirements.
Engine counterpart tracked by bz#1024010.
Change-Id: Id46f85b94937779ea899b05dd1bfa73780a1a4e9
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1024007
Signed-off-by: Amador Pahim <[email protected]>
commit 9e608c41bb7789fc20d6cbc6068caec52336d0ae
Author: Vinzenz Feenstra <[email protected]>
Date: Mon Apr 7 16:13:01 2014 +0200
agent: setNumberOfCPUs support
Change-Id: I0b03bd96bd52b76e7d3bf1f8bbcdd7d8e8fbc560
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit 01939815964c4bcb976702faa5da9d68cdc3f051
Author: Vinzenz Feenstra <[email protected]>
Date: Tue Apr 29 11:33:09 2014 +0200
Try to load the virtio_console module before starting
Change-Id: I124bf87f940dae09cb237439e213326a8747938a
Bug-Url: https://bugzilla.redhat.com/1061139
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit 2856433a70b20d0dda20d8c6e53cc0f172f598a2
Author: Vinzenz Feenstra <[email protected]>
Date: Mon Apr 14 17:28:18 2014 +0200
Init script for SLES
Change-Id: Ic647c42e986937cc5e18cb40bec7023997e6dd1c
Bug-Url: https://bugzilla.redhat.com/1043471
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit bbe5e9751017f499a9b36056f4042f9e99d22e68
Author: Vinzenz Feenstra <[email protected]>
Date: Thu Apr 10 13:51:23 2014 +0200
Remove trailing whitespaces in configuration files
Change-Id: I6caa2a32f924d787c2f2db08d33bcc511b7e41e3
Bug-Url: https://bugzilla.redhat.com/1043471
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit a0ee5679aff2a122b98c264ba41072c19e5836de
Author: Vinzenz Feenstra <[email protected]>
Date: Thu Apr 10 13:45:38 2014 +0200
List of SUSE packages
Change-Id: I209a8f466ffb6152d2f9f43e8651df9e5d01413e
Bug-Url: https://bugzilla.redhat.com/1043471
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit 2fc297ea523a2bc4a0b94141dda638e0b5fc954a
Author: Vinzenz Feenstra <[email protected]>
Date: Thu Apr 10 13:34:14 2014 +0200
m4: Detect SUSE
Change-Id: Ic5dda77121a7ccb1e77604324c06bda720ca05d0
Bug-Url: https://bugzilla.redhat.com/1043471
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit f17e052aba4435e607f5b5d06e7b97a412dda378
Author: Vinzenz Feenstra <[email protected]>
Date: Thu Apr 10 12:16:56 2014 +0200
Added support for sudo
This patch introduces configure controlled choice of the elevation mechanism
used on the system.
configure has now a new option --with-sudohelper=[usermode|sudo]
Values:
- usermode: elevation via consolehelper and pam
- sudo: elevation via sudo
Change-Id: I202c1bbea8c95f5ad12edb4959a7d614c89ea246
Bug-Url: https://bugzilla.redhat.com/1043471
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit 9f69e31195aeb439734d6158a5c0ab0a1abc3050
Author: Vinzenz Feenstra <[email protected]>
Date: Fri Apr 18 11:37:51 2014 +0200
win32: Retrieve the active session through enumeration
Using WTSGetActiveConsoleSessionId() does in case of RDP connections give
a session id which is not corresponding to the users session in some cases.
By enumerating through the sessions and retriving the session with the 'State'
'WTSActive' we are able to reliably retrieve the current active session.
This is required in order to get the logged-in user and being able to retrieve
the user token for performing operations in their name.
Change-Id: I569d4b6b80e102b83b7e6e39c12524f2d588ad37
Bug-Url: https://bugzilla.redhat.com/1068750
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit 1367a3436b66010a05542342ab5e8966a6e85f67
Author: Vinzenz Feenstra <[email protected]>
Date: Mon Apr 7 11:12:41 2014 +0200
agent: Report number of CPU cores visible online on the guest OS
This patches a new message and increases the Guest Agent API to
version 1.
The new message has this format:
{"__name__": "number-of-cpus", "count": <int>}
The reported number 'count' is the number of visible online CPU cores
on the guest OS system.
Change-Id: Ief777608519a35319665c4cd0f580b7b38305b3e
Guest-Agent-API-Version: 1
Bug-URL: https://bugzilla.redhat.com/show_bug.cgi?id=1063280
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit 906949e7f8e2936bbd7a268b3adcb0b676783aab
Author: Vinzenz Feenstra <[email protected]>
Date: Wed Jul 17 11:05:51 2013 +0200
agent: Implement basics for API Versioning
This commit introduces the basics needed to support API versioning between
the ovirt-guest-agent and VDSM.
How the negotiation works:
- VDSM has as a default the apiVersion value set to _DISABLED_API_VALUE marking
it as unsupported
- The guest agent sends its max supported version with every `heartbeat`
message
- VDSM checks that `apiVersion` exists in the `heartbeat` message arguments
- If it exists it retrieves the minimum common version and sends the
`api-version` message with the common version as `apiVersion` argument
- If it does NOT exist it and the apiVersion is not set to
_DISABLED_API_VALUE it will set it to _DISABLED_API_VALUE, with the meaning
that it is not supported at all by the guest agent on the other end.
- The guest agent on receiving this message makes it own check and sets the
`apiVersion` to the commonVersion
- If VDSM sends the `refresh` command it also sends its `apiVersion` value
however if it does not, capable guest agents are disabling the versioning
support and will know it in pre-supported state as well.
NOTE: VDSM will never send an api-version message without being triggered.
This is to ensure backwards compatibility.
Change-Id: I754d52009538914dd0143894b24ad48fbf13cb38
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit 723de8e6075a255cf49df0d16b03cce185580a21
Author: Vinzenz Feenstra <[email protected]>
Date: Tue Feb 18 11:28:26 2014 +0100
Implementation of logind based session locking
Support screen lock for logind based systems, since ConsoleKit
is no longer developed in the long run this will be the way to
go.
Change-Id: Iafc4b88d9c508647e1d09407556359fbefbba34c
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit 5168c478284fa75e1b1a19940233be493560ef12
Author: Vinzenz Feenstra <[email protected]>
Date: Mon Jan 20 14:42:35 2014 +0100
Version 1.0.9 update
Change-Id: I4a914522846fb879ed09c47992bc5f13d0456ead
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit bfeb7ce71086d7b5fe7ef061bc05eec42b6176b6
Author: Vinzenz Feenstra <[email protected]>
Date: Mon Jan 27 12:39:01 2014 +0100
Build fixes
* Don't execute PEP8 checks when PEP8 is not installed
* configure.ac: Don't fail on systems where AM_PROG_AR is not yet
available in automake
* m4/fhs.m4 don't fail if neither /var/lock/subsys nor /var/lock
are present
Change-Id: Iaa33a029b2e8fbbbd2e1329814dd8dc182109552
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit 52b97cfbd5f1a4378b0be168ffd8293e29f99f46
Author: Vinzenz Feenstra <[email protected]>
Date: Mon Jan 20 14:28:47 2014 +0100
packaging: Depend on the qemu-guest-agent
For support of freezing and thawing the filesystem for the
Backup and Restore API feature of oVirt
Change-Id: I4c550801326dfa0b8d9357770f48a6d9b64eb3a1
Bug-Url: https://bugzilla.redhat.com/1055524
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit 17d61aa3be1f85b70f72bb2756f8b3f046db3de8
Author: Gal Hammer <[email protected]>
Date: Mon Jan 13 15:20:00 2014 +0200
agent: handle failures on Windows' write requests.
Windows' virtio-serial driver behavior was changed so a write
request when the host is not connected results in immediate
return with an error.
Change-Id: I28ca3c1115f6b18295a29d1f87bf3144c00759e1
Signed-off-by: Gal Hammer <[email protected]>
Bug-Url: https://bugzilla.redhat.com/1026474
commit 8ad7e901e70fe40fa885bbbeb0b530dccefdc34f
Author: Vinzenz Feenstra <[email protected]>
Date: Thu Oct 10 12:15:08 2013 +0200
pam: Fix the pam conversation approach
Until now our PAM conversation was errorneous using pam_get_user
which is not correct for requests other than accquiring the username.
To correctly request the Token from the frontend we have to use a PAM
conversation. This is done via the pam_prompt function.
We also do check now, if the requesting user (if set) is identical with
the preset user. If this is not the case we will not unlock the screen.
Preset users should only be available if the screen was locked.
If the usernames aren't equal, the module will return PAM_CRED_UNAVAIL.
Additionally the logging was rewritten to use the syslog and more comments
have been added to describe the steps we're doing.
Change-Id: I4455ea61ffb27e854fe93bdc51068e12617955a2
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit c39f0c2d4cb71c761cbb4447d680c4e11d4de19c
Author: rexcze <[email protected]>
Date: Wed Nov 20 17:22:52 2013 +0100
Update README-windows.txt
python OVirtGuestService.py install should be without "-" near install to work as expected. Tested on 3.3. and windows 2003 and 2008
Change-Id: I0e5eb8a6a78a9a6c1a036a4fb451e75bb6fb2d3e
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit 08a588cfde023ea78bc509511323cdac3eaca7cb
Author: Vinzenz Feenstra <[email protected]>
Date: Mon Nov 4 10:43:12 2013 +0100
agent: Report swap usage of the guests
Change-Id: I09f1c0dbbe12eee352637c97a4fa23835d14307a
Bug-Url: https://bugzilla.redhat.com/1025845
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit 8c7738a2e56a6fee73cacbd9ddbc36ca8577ee13
Author: Vinzenz Feenstra <[email protected]>
Date: Wed Oct 9 08:11:55 2013 +0200
Fixed package name in ovirt-guest-agent.conf
The package is called ovirt-guest-agent-common now, if searched for
the package in the package database.
Change-Id: Ia647838379e5823a8451721ed3f76c248e59e234
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit d55dbd69c717f48a56d5aa6c5847252781478003
Author: Zhou Zheng Sheng <[email protected]>
Date: Fri Sep 13 21:06:57 2013 +0800
Ubuntu packaging: add python-nose to build requirements
"make check" during the build process runs tests which import
python-nose modules.
Change-Id: I529b4fe19e191cf2551943f2ed132edee7349ac0
Signed-off-by: Zhou Zheng Sheng <[email protected]>
commit 4013bc70ede921b99bc47d0ae096583f3527a842
Author: Zhou Zheng Sheng <[email protected]>
Date: Wed Sep 18 11:17:07 2013 +0800
Ubuntu Packaging: add python-apt to dependency
In ovirt-guest-agent/GuestAgentLinux2.py we try to import apt module.
This module is provided by python-apt on Debian and Ubuntu. This patch
adds python-apt to package dependency.
Change-Id: I7a248b43c541ded03a26625896881d89a0d6401d
Signed-off-by: Zhou Zheng Sheng <[email protected]>
commit 7ceef1528359bea44aa2f705318bff1bbfb9d7a6
Author: Martin Betak <[email protected]>
Date: Wed Sep 11 17:26:21 2013 +0200
agent: Fix python-2.4 compatibility
Rewrote the use of ternary operator to if since it is not
supported in python-2.4.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1006861
Change-Id: I03c63477a2d2bcb9eb4c4307946a3486300663e1
Signed-off-by: Martin Betak <[email protected]>
commit bb587ab97da7d67faa029d5a9a613ad244468029
Author: Zhou Zheng Sheng <[email protected]>
Date: Thu Sep 5 09:25:36 2013 +0800
Packaging: Add the missing dependencies
automake and pkg-confg are needed when building ovirt-guest-agent in a
fresh Ubuntu environment.
This patch also split each dependency to separated lines. The debhelper
is a boilerplate so leave it at the first line. The other lines are
custom dependencies so sort them to make it easier to maintain.
Change-Id: I90f86100946c5b60cc816e664a2857cad5b4b0f5
Signed-off-by: Zhou Zheng Sheng <[email protected]>
commit 1ed717196ff4a38766b5ec22eafb42e54ca99fa1
Author: Vinzenz Feenstra <[email protected]>
Date: Tue Sep 10 12:20:09 2013 +0200
Replaced String check with string conversion
Currently the string_check is destroying the data when the system
is not able to convert them properly.
This is now fixed by allowing unicode strings as they are
and an attempt of decoding input (non-unicode) strings based
on the prefered locale encoding.
If this will fail, the replacement of unknown characters are applied.
In any case an unicode string is created. If the string is not
convertible, the return value will be "????" as a replacement.
This however is the last resort, to allow at least some level of
data to go through. (e.g. when the application list contains one
invalid data string currently it would cause the whole list NOT to
be sent. Now it will be sent)
Please also note that this commit will fix the failing unit tests.
Change-Id: Ie277069cbfa39f9735a2b85b9e9da9c3fcfe5938
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit 6d3aa51d6ba0256ff6915e6b551a86ab8cb3d3b8
Author: Vinzenz Feenstra <[email protected]>
Date: Thu Sep 5 15:47:09 2013 +0200
Adding Unit Tests and Functional Tests
The functional tests so far are testing the retrieval
of data from the underlying system and ensures the structure
of the data. It does not however validate the content.
It ensures that the messages sent over the VirtIO Serial
channel have the format defined.
If we change the format it will break the unit tests.
Additionally a check for the unicode filtering.
Change-Id: I4c1d740c948e33aed8a04a1013b22276cf7d85e3
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit e90629f193c5eb0bebaf37963b336566db819e54
Author: Vinzenz Feenstra <[email protected]>
Date: Mon Sep 9 12:22:09 2013 +0200
Revert "Remove contra productive _string_check"
This reverts commit b06a6c4c8e61013b7461c6fc946c1530ae47584e.
The previous commit breaks the guest agent badly because the
string type is required to be unicode, this code previously was
converting it most of the times to unicode, however in some cases
it won't do so and causes the data to be an ascii string or even
replaces valid characters even though it should not.
The attempt for fixing this issue will be addressed by a new patch.
Change-Id: I47176ac60e069e7d557312d7047d9bc4b15ac768
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit b06a6c4c8e61013b7461c6fc946c1530ae47584e
Author: Vinzenz Feenstra <[email protected]>
Date: Tue Sep 3 12:29:10 2013 +0200
Remove contra productive _string_check
_string_check is rather harmful when using the new filtering. It creates
non-unicode strings out of valid strings.
The new unicode validation code covers the boundaries much better than
_string_check therefore we remove it.
Change-Id: Id01d8dc1374ae33435c5aefaae559ab8aa0ff062
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit c24385fab64a0192c0dee8092c9bb1c2c235b815
Author: Vinzenz Feenstra <[email protected]>
Date: Wed Jan 23 12:47:14 2013 +0100
agent: ovirt-guest-agent version 1.0.8
ChangeLog updated
Change-Id: I71b6165b799a730bfe1b3559b8840b0457af997a
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit ecae245160db3b90c820a5cabe8134bad3a55b5a
Author: Vinzenz Feenstra <[email protected]>
Date: Wed Jun 26 16:48:43 2013 +0200
agent: Report FQDN of the machine
Sending now the fqdn message on refresh and startup
Change-Id: I5d91de94b9ebd4448e9761ce597d970029ca3837
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit 7487859794205e6bdff7df66948e6028c7f336bd
Author: Vinzenz Feenstra <[email protected]>
Date: Tue Jul 16 13:51:07 2013 +0200
agent: Disable GDM plugin building on Fedora 19+
Fedora 19 does no longer have a GDM with plugin capabilities.
To allow proper building of the package gdm plugins are no longer
built for Fedora 19 and higher.
Change-Id: Iff3f5a3c7c12d9c6ef198aefe163d9633d8364b3
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit d05fc4f46c05a6b1b15c8139c372459631e78834
Author: Vinzenz Feenstra <[email protected]>
Date: Tue Jul 16 13:48:34 2013 +0200
agent: Missing BuildRequirements in spec files
The following two packages are missing in the build requires
* python-pep8
* gcc-c++
Change-Id: I997a0fd3653688271cfd5ad7ee584d8b6ed1c11d
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit b1e7d5c3a11214cc20df25f0ba57cb4234222dd3
Author: Vinzenz Feenstra <[email protected]>
Date: Tue Jul 16 13:46:36 2013 +0200
agent: Default value for configure should be without-dist
Change-Id: Ie1f84f06f7a188e59c181a1190ab5a133873cee7
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit 2d99359232c8cdd544d192efd3a47603b425e784
Author: Vinzenz Feenstra <[email protected]>
Date: Mon Jul 15 17:27:02 2013 +0200
agent: Reworking the data filtering for the guest agent
This patchset is oriented on http://gerrit.ovirt.org/#/c/16652
We're now filtering properly invalid unicode characters and invalid
characters. Which would cause VDSM to build invalid XML data.
Change-Id: I3a4347350d791f4df0b26b1cf81d0ca4f9656981
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit 281d5432d18bf191ec2890b21ff6fdb7c81069ec
Author: Martin Betak <[email protected]>
Date: Thu Jun 6 15:44:30 2013 +0200
agent: Support reboot as optional shutdown parameter
Added optional boolean parameter determining whether to pass the '-r'
parameter to the appropriate shutdown script.
Change-Id: I94929ff49677ee79569117158c53bdaf086b3ae8
Signed-off-by: Martin Betak <[email protected]>
commit 1ad924dfec7344edb8540544518d60117429800e
Author: Vinzenz Feenstra <[email protected]>
Date: Mon Jul 8 13:29:50 2013 +0200
agent: condrestart should check also for pidfile size
Change-Id: Ia2dff34095430147116491337ea528594cb6ab04
Bug-Url: https://bugzilla.redhat.com/977943
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit c4475ac271495d89294664e58157d651c9833ce2
Author: Vinzenz Feenstra <[email protected]>
Date: Tue May 7 14:08:33 2013 +0200
agent: Use python 2.4 syntax in GuestAgentLinux2
Change-Id: I37c570c2cca4a71f15173601aaed27522e01e895
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit 412ae0c24ead168907ffbe17ab8b4946ae2e7d06
Author: Vinzenz Feenstra <[email protected]>
Date: Thu Jul 11 09:02:30 2013 +0200
agent: Add possibility to NOT build kdm and/or gdm extensions
Since with GNOME 3.8 it's no longer possible to build extensions for GDM
we're now allowing to disable the build of the extensions for systems
not supporting it.
Additionally we're now allowing a better control via configure what to build.
Change-Id: I87745ea0e49860969d782c35e2e83cec12fff864
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit ae56cffd363217964b0079ef75cb88b84e8f5cf3
Author: Vinzenz Feenstra <[email protected]>
Date: Wed Jul 10 16:32:53 2013 +0200
agent: Adding --with-dist for packaging ease
Since not all platforms can fullfill the requirements of the
configure script, but tar balls need to be creatable anyway,
add a --with-dist to configure for being able to create the
distribution tarballs anywhere.
--with-dist on configure now disables the requirement checks.
This is needed as for example F19 or RHEL6/CentOS won't be able
to fulfill the requirements for the GDM plugin.
Change-Id: If1daa4438d9037d47ed4e7ee0be35cb1c2755779
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit f2d30e7466dc7f582d25687d841280f96d7fac15
Author: Vinzenz Feenstra <[email protected]>
Date: Wed Jul 10 16:25:21 2013 +0200
agent: RHEL6 spec file
Adding a RHEL6 specific spec file for the ovirt-guest-agent
Change-Id: Ife545bcfc597a3c0227ec1b17258234b87b2df7a
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit 2f001d67d44902dd93d99e02537c0f9e8c9b9287
Author: Vinzenz Feenstra <[email protected]>
Date: Tue Apr 2 18:13:47 2013 +0800
agent: Build and install ovirt guest agent on Ubuntu
Implemented necessary changes for making the oVirt Guest Agent
working on Ubuntu and Fedora.
Change-Id: I7a694bf1f7ff4230bac305dd571899265ef63950
Signed-off-by: Zhou Zheng Sheng <[email protected]>
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit 15e3f8d01bca1ef49c649ade8c0c99a8566ebba0
Author: Vinzenz Feenstra <[email protected]>
Date: Mon Jun 10 09:18:35 2013 +0200
agent: Do not install Windows files on linux
Change-Id: Ic7cdb66b2b154901541010135ddf118893182ec9
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit fec9cb42a0bc193071b7be0d473c1b5418d5c3ef
Author: Vinzenz Feenstra <[email protected]>
Date: Wed May 15 09:39:35 2013 +0200
agent: Use the locale module to get the preferred encoding
The guest agent used for the string sanitization sys.stdout.encoding
which is set to None when you're running without an allocated console.
This is the case on Windows as a service. The locale module provides
the function getpreferredencoding() which returns the required value.
Resolves: BZ#962667
Change-Id: I9ff6e3c7165599f80d13115e0173eefe0e79e664
Bug-Url: https://bugzilla.redhat.com/962667
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit 0d9280ec109e0bd6c693999a4c036e70d9324860
Author: Vinzenz Feenstra <[email protected]>
Date: Thu Apr 4 15:54:07 2013 +0200
agent: Send non-blocking uninstalled notification without python
Remove the inline python script to send the non-blocking uninstalled
message and replace it with echo + dd
Change-Id: I8b2f84d56377ba4ba42ee206966b7b68deae7fc9
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit 67589a7ecbf5dc98d08a7383c2fbf9c90512da5b
Author: Vinzenz Feenstra <[email protected]>
Date: Fri Apr 5 09:49:02 2013 +0200
agent: Ignore usbfs filesystems'
Change-Id: Iee799b05f3c700e8e3912305e2984dad6e049f7d
Bug-Url: https://bugzilla.redhat.com/947792
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit de1daabc1453c2ae3a6e0f27971f36cc865b05d5
Author: Zhou Zheng Sheng <[email protected]>
Date: Thu Apr 11 13:23:57 2013 +0800
agent: avoid failing to get disk stat when deal with gvfs-fuse
gvfs-fuse filesystem prevents other user from stat it. Even root can not
stat other user's gvfs-fuse fs. Stat on it fails then the whole disk
stat function fails.
This patch skips gvfs-fuse related filesystem when collecting disk stat.
Moreover, this patch try..except in a finner per fs granularity, so that
failing on stat one fs does not fails the whole operation.
Change-Id: I69c674904c2ad9cb508c5294591a8ba0813e4238
Signed-off-by: Zhou Zheng Sheng <[email protected]>
commit f44af16c872a2aceb31bae2c0e93eca1f8a40556
Author: Vinzenz Feenstra <[email protected]>
Date: Tue Mar 26 15:31:03 2013 +0100
agent: Recommend python 2.7.3 for windows in the README
Change-Id: Ib051c8f8890e70c3382f366f7272c51f9e711162
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit 1c77f2661b9ccc3f8897788363ac8600f0b4037f
Author: Vinzenz Feenstra <[email protected]>
Date: Tue Mar 26 15:15:15 2013 +0100
agent: Windows Guest - ini file lookup
The ini file is now expected to be in the same folder as the service
executable.
Change-Id: I4d1927a429fcb780119f78f8dc05999f3bae9148
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit d73a85e5ce30fe689d0764d99342c6206fae0e62
Author: Vinzenz Feenstra <[email protected]>
Date: Tue Mar 26 11:26:30 2013 +0100
agent: Include windows files in tar balls
In order to be able providing source tar balls and src zips containing
all possible build targets we're now including all files necessary.
Previously we did not include all files and it was necessary to
checkout the source git repository to be able building windows
targets for the guest agent.
This commit provides the necessary changes to include all necessary
files for building it from source tar balls.
Change-Id: I793b84ac78127593a11ab9894fdbc68fa45d224d
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit 9e7a4f08bee74e3bd9e6b223cdb041f7b5984c4c
Author: Vinzenz Feenstra <[email protected]>
Date: Thu Apr 4 14:15:40 2013 +0200
agent: Perform string sanitization on messages
Messages sent via VirtIO are now checked for being presentable
and additionally filtered for invalid characters due to invalid
encodings.
Change-Id: I499a22e1572b55d1a3a4de7ce6f89ebb130861a8
Bug-Url: https://bugzilla.redhat.com/947014
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit 61af838faaf017a4f3d31dd2d0246db8a9983154
Author: Vinzenz Feenstra <[email protected]>
Date: Thu Feb 21 13:35:04 2013 +0100
agent: Add a configure option to disable SSO
We don't support SSO on all systems, therefore we should at least make
it possible to build the guest agent daemon for those systems
Change-Id: Ic00e4c781a47194bbf6eda62fe3b4f1f107bbbbe
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit 2b0260bb267c5b5c539bfae1158845554c267a17
Author: Vinzenz Feenstra <[email protected]>
Date: Tue Mar 26 11:07:20 2013 +0100
Added myself to AUTHORS
Change-Id: I541d0ecdf6e623210c5ecd89cdb694cb90e199c2
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit 20e08c2c9ee7d3721e57c98dffbd2f55d282ac37
Author: Vinzenz Feenstra <[email protected]>
Date: Mon Jan 14 10:22:56 2013 +0100
agent: Fixing .gitattributes
.gitattributes should contains text infront of eol
Change-Id: Iec9a241e05c2c6c9a3922de0c9153e97406118eb
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit c61fabb746b3a7f3e6f8c166578be193b13ed4d4
Author: Vinzenz Feenstra <[email protected]>
Date: Tue Jan 8 15:16:03 2013 +0100
agent: Running PEP8 checks on python files
Change-Id: Ie41f1126dfd124e393ae11e9c4c054c7c23ce7aa
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit 51be0250673f7b81aeb80ecd0183f255e0606a9e
Author: Vinzenz Feenstra <[email protected]>
Date: Wed Dec 26 09:24:47 2012 +0100
agent: Pep8 fixes
* CredServer
* GuestAgentLinux2
* VirtIoChannel
* WinFile
* version
* setup.py - FP on py2exe import
* OVirtGuestAgent
* OVirtAgentLogic
* ovirt-guest-agent
* LockActiveSession
* GuestAgentWin32
Change-Id: I74c33ed2ef2e5c33b9d25cb8b38e4201d67a957b
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit f5db1a06b8793fa2306c4a387c77dd1f43771e98
Author: Vinzenz Feenstra <[email protected]>
Date: Wed Jan 23 12:33:12 2013 +0100
agent: Call restorecon on pidfile
Change-Id: I8729ce8018566b400846e0d639dfdb6b11d51862
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit 767acc9d433cabd267a6c7f06f314db9e35c45ae
Author: Vinzenz Feenstra <[email protected]>
Date: Thu Feb 14 17:25:05 2013 +0100
agent: Reported MAC on Windows now the same as on Linux
Reporting of the MAC differs between linux and Windows guest operating
systems. The windows operating system reports it separated by dashes '-'.
This changeset will replace those dashes with colons ':'
Change-Id: Id19a8944025ee22d82a57b99fe4ba1c4315c27e9
Bug-Url: https://bugzilla.redhat.com/908761
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit 1c35798a95890bf90764eb4ee4a38e027f9410b7
Author: Vinzenz Feenstra <[email protected]>
Date: Thu Feb 14 17:18:34 2013 +0100
agent: Sorted gitignore and added .idea
Change-Id: Iad052f3d272b5df68275de9baeac3f9e45ea32c5
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit 517cf4082f027e2496128e8bfe4fdf2149fa33a0
Author: Vinzenz Feenstra <[email protected]>
Date: Tue Feb 19 13:50:59 2013 +0100
agent: datadir as default home for the ovirtagent user
Solves the issue with starting the service when polyinstantiated
namespaces are used on the system.
Following the Fedora guideline:
http://fedoraproject.org/wiki/Packaging:UsersAndGroups
Bug-Url: https://bugzilla.redhat.com/883124
Change-Id: I08cd6e8ca4341c62c0e5f18b6c6226a103873f62
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit 31a6af39ad0138e4482b53cddbd3d36d04a67e5c
Author: Dan Kenigsberg <[email protected]>
Date: Thu Jan 3 15:00:57 2013 +0200
Report multiple IPv4 addresses per device if available
A future version of python-ethtool is going to expose
ethtool.etherinfo.get_ipv4_addresses() method, reporting multiple
addresses of a single device. Use this method if available.
Signed-off-by: Dan Kenigsberg <[email protected]>
Change-Id: I77bfd63874134b8d0c626c6d179643c2ec781b44
commit d2defa34e0572cb72ea65c977fb2948bce72008c
Author: Gal Hammer <[email protected]>
Date: Sun Dec 30 10:00:20 2012 +0200
agent: Send 'uninstalled' notification non blocking
The "echo" command blocks if the host is not connected to the
virtio-serial port. Replace it with a short python script that
opens the port with the O_NONBLOCK flag. This way, removing the
agent's doesn't hung if vdsm (or any other listener) doesn't
exist during the removal.
Change-Id: I5b49e53cda2f21bd759b0f3f67619f7f1e45688f
Signed-off-by: Gal Hammer <[email protected]>
Signed-off-by: Vinzenz Feenstra <[email protected]>
commit 172f4b48caf99d1b22271b2f64561c992a3b2751
Author: Gal Hammer <[email protected]>
Date: Thu Dec 27 10:55:48 2012 +0200
agent: fixed "modified" files after clone.
Due to CR/LF issue some files were reported as "modified" even after
new clone or hard reset. Recommited the files with the right line-
ending.
Change-Id: I147b60f91335e18d786f79e3ab5d3799c1b18ab8
Signed-off-by: Gal Hammer <[email protected]>