Skip to content

Conversation

@chong-he
Copy link
Member

Fix the beacon API for pending_deposits and pending_partial_withdrawals on the client side to return version, see #8251 (comment)

@chong-he chong-he added ready-for-review The code is ready for review HTTP-API labels Oct 29, 2025
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Oct 29, 2025
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this just need a tick for mergify to merge (I have not reviewed this)

@mergify mergify bot added the queued label Oct 30, 2025
@michaelsproul
Copy link
Member

Oops thought I approved

mergify bot added a commit that referenced this pull request Oct 30, 2025
@mergify mergify bot merged commit af9cae4 into sigp:unstable Oct 30, 2025
37 checks passed
@mergify mergify bot removed the queued label Oct 30, 2025
eserilev pushed a commit to eserilev/lighthouse that referenced this pull request Oct 30, 2025
@chong-he chong-he deleted the api-response-version branch October 30, 2025 22:38
eserilev pushed a commit to eserilev/lighthouse that referenced this pull request Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HTTP-API ready-for-merge This PR is ready to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants