Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure SingleAttestation conversion happens on the BeaconProcessor #6805

Open
michaelsproul opened this issue Jan 15, 2025 · 0 comments
Open

Ensure SingleAttestation conversion happens on the BeaconProcessor #6805

michaelsproul opened this issue Jan 15, 2025 · 0 comments
Assignees
@eserilev
Labels
electra Required for the Electra/Prague fork optimization Something to make Lighthouse run more efficiently.

Comments

@michaelsproul
Copy link
Member

Description

In our SingleAttestation MVP, the conversion from SingleAttestation to Attestation happens on the main Tokio executor:

We should ensure this is optimised out prior to shipping Electra. Some ideas for that here:

The other option is to more wholeheartedly embrace SingleAttestation:
@michaelsproul michaelsproul added optimization Something to make Lighthouse run more efficiently. electra Required for the Electra/Prague fork labels Jan 15, 2025
@michaelsproul michaelsproul changed the title Ensure SingleAttestation conversion happens _on_ the BeaconProcessor Ensure SingleAttestation conversion happens on the BeaconProcessor Jan 15, 2025
@michaelsproul michaelsproul mentioned this issue Jan 15, 2025
Merged
@eserilev eserilev self-assigned this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eserilev eserilev

Labels
electra Required for the Electra/Prague fork optimization Something to make Lighthouse run more efficiently.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelsproul @eserilev