Skip to content

Sync to deal with HandlerReject #2578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AgeManning opened this issue Sep 9, 2021 · 1 comment
Closed

Sync to deal with HandlerReject #2578

AgeManning opened this issue Sep 9, 2021 · 1 comment
Assignees

Comments

@AgeManning
Copy link
Member

Description

I've seen multiple instances when first booting and connecting to a single peer the peer immediately tries to disconnect, but not before sending a status to us. Sync then tries to download blocks from the single peer, but the RPC is in a shutdown state and returns an RPC Error of HandlerReject. As this is an internal tracking mechanism, we don't penalize the peer, but the sync algorithm continually retries to download blocks from the peer.

The algorithm should stop after 5 failed attempts, however there seems to be a loop going on that I didn't track. Alternatively, we should handle the HandleReject error in the sync algo's and remove the peer as a candidate from syncing blocks.

@AgeManning
Copy link
Member Author

#2615 was the source of this error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants