Skip to content

Commit 999b045

Browse files
authored
Merge pull request #7525 from jimmygchen/mergify-again
Update mergify to prevent incorrectly firing rule to update `ready-for-review` label
2 parents 7759cb8 + 9e9c51b commit 999b045

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

.github/mergify.yml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,17 +48,16 @@ pull_request_rules:
4848
# CI workflows approvals.
4949
- check-success=test-suite-success
5050
- check-success=local-testnet-success
51-
- "#review-requested > 0"
51+
# Update the label only if there are no more change requests from any reviewers and no unresolved threads.
52+
# This rule ensures that a PR with passing CI can be marked as `waiting-on-author`.
53+
- "#changes-requested-reviews-by = 0"
54+
- "#review-threads-unresolved = 0"
5255
actions:
5356
label:
5457
remove:
5558
- waiting-on-author
5659
add:
5760
- ready-for-review
58-
comment:
59-
message: >
60-
All required checks have passed and there are no merge conflicts.
61-
This pull request may now be ready for another review.
6261

6362
- name: Close stale pull request after 30 days of inactivity
6463
conditions:

0 commit comments

Comments
 (0)