Skip to content

Commit 8f7dcf0

Browse files
authored
Fix unaggregated delay metric (#8366)
while working on this #7892 @michaelsproul pointed it might be a good metric to measure the delay from start of the slot instead of the current `slot_duration / 3`, since the attestations duties start before the `1/3rd` mark now with the change in the link PR. Co-Authored-By: hopinheimer <[email protected]> Co-Authored-By: hopinheimer <[email protected]>
1 parent 1e10329 commit 8f7dcf0

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

beacon_node/beacon_chain/src/metrics.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1185,7 +1185,7 @@ pub static VALIDATOR_MONITOR_UNAGGREGATED_ATTESTATION_DELAY_SECONDS: LazyLock<
11851185
> = LazyLock::new(|| {
11861186
try_create_histogram_vec(
11871187
"validator_monitor_unaggregated_attestation_delay_seconds",
1188-
"The delay between when the validator should send the attestation and when it was received.",
1188+
"The delay between when the validator sent the attestation and the start of the slot.",
11891189
&["src", "validator"],
11901190
)
11911191
});

beacon_node/beacon_chain/src/validator_monitor.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1214,7 +1214,7 @@ impl<E: EthSpec> ValidatorMonitor<E> {
12141214
let delay = get_message_delay_ms(
12151215
seen_timestamp,
12161216
data.slot,
1217-
slot_clock.unagg_attestation_production_delay(),
1217+
Duration::from_secs(0),
12181218
slot_clock,
12191219
);
12201220

0 commit comments

Comments
 (0)