Skip to content

Commit 7b1cbca

Browse files
authored
Downgrade and remove unnecessary logs (#8367)
### Downgrade a non error to `Debug` I noticed this error on one of our hoodi nodes: ``` Nov 04 05:13:38.892 ERROR Error during data column reconstruction block_root: 0x4271b9efae7deccec3989bd2418e998b83ce8144210c2b17200abb62b7951190, error: DuplicateFullyImported(0x4271b9efae7deccec3989bd2418e998b83ce8144210c2b17200abb62b7951190) ``` This shouldn't be logged as an error and it's due to a normal race condition, and it doesn't impact the node negatively. ### Remove spammy logs This logs is filling up the log files quite quickly and it is also something we'd expect during normal operation - getting columns via EL before gossip. We haven't found this debug log to be useful, so I propose we remove it to avoid spamming debug logs. ``` Received already available column sidecar. Ignoring the column sidecar ``` In the process of removing this, I noticed we aren't propagating the validation result, which I think we should so I've added this. The impact should be quite minimal - the message will stay in the gossip memcache for a bit longer but should be evicted in the next heartbeat. Co-Authored-By: Jimmy Chen <[email protected]>
1 parent 8f7dcf0 commit 7b1cbca

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

beacon_node/network/src/network_beacon_processor/gossip_methods.rs

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -735,12 +735,11 @@ impl<T: BeaconChainTypes> NetworkBeaconProcessor<T> {
735735
// Data column is available via either the EL or reconstruction.
736736
// Do not penalise the peer.
737737
// Gossip filter should filter any duplicates received after this.
738-
debug!(
739-
%slot,
740-
%block_root,
741-
%index,
742-
"Received already available column sidecar. Ignoring the column sidecar"
743-
)
738+
self.propagate_validation_result(
739+
message_id,
740+
peer_id,
741+
MessageAcceptance::Ignore,
742+
);
744743
}
745744
GossipDataColumnError::FutureSlot { .. }
746745
| GossipDataColumnError::PastFinalizedSlot { .. } => {

beacon_node/network/src/network_beacon_processor/mod.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -866,6 +866,9 @@ impl<T: BeaconChainTypes> NetworkBeaconProcessor<T> {
866866
"Reconstruction not required for block"
867867
);
868868
}
869+
Err(BlockError::DuplicateFullyImported(_)) => {
870+
debug!("Block already imported in parallel with reconstruction");
871+
}
869872
Err(e) => {
870873
error!(
871874
%block_root,

0 commit comments

Comments
 (0)