add todo for is_parent_block_full

Author: shane-moore

consensus/state_processing/src/per_block_processing.rs

@@ -522,7 +522,8 @@ pub fn compute_timestamp_at_slot<E: EthSpec>(
 
 /// Compute the next batch of withdrawals which should be included in a block.
 ///
-/// https://ethereum.github.io/consensus-specs/specs/_features/eip7732/beacon-chain/#modified-get_expected_withdrawals
+/// https://ethereum.github.io/consensus-specs/specs/gloas/beacon-chain/#modified-get_expected_withdrawals
+#[allow(clippy::type_complexity)]
 pub fn get_expected_withdrawals<E: EthSpec>(
     state: &BeaconState<E>,
     spec: &ChainSpec,
@@ -540,7 +541,7 @@ pub fn get_expected_withdrawals<E: EthSpec>(
             let mut processed_builder_withdrawals_count = 0;
             for withdrawal in builder_pending_withdrawals {
                 if withdrawal.withdrawable_epoch > epoch
-                    || withdrawals.len() + 1 == E::max_withdrawals_per_payload()
+                    || withdrawals.len().safe_add(1)? == E::max_withdrawals_per_payload()
                 {
                     break;
                 }

consensus/state_processing/src/per_block_processing/process_withdrawals.rs

@@ -110,6 +110,20 @@ pub mod capella {
 }
 pub mod gloas {
     use super::*;
+
+    // TODO(EIP-7732): Add comprehensive tests for Gloas `process_withdrawals`:
+    // - Test builder_pending_withdrawals processing and removal
+    // - Test is_builder_payment_withdrawable conditions (slashed vs unslashed builders)
+    // - Test latest_withdrawals_root computation
+    // - Test interaction with is_parent_block_full()
+    // - Test partial withdrawals processing
+    // Similar to Capella version, these will be tested via:
+    // 1. EF consensus-spec tests in `testing/ef_tests/src/cases/operations.rs`
+    //    (see WithdrawalsPayload handler, lines ~390-430)
+    // 2. Integration tests via full block processing
+    // Once Gloas blocks can be properly constructed, add test cases to EF test suite.
+    // These tests would currently fail due to incomplete Gloas block structure as mentioned here, so we will implement them after block and payload processing is in a good state.
+    // https://github.com/sigp/lighthouse/pull/8273
     /// Apply withdrawals to the state.
     pub fn process_withdrawals<E: EthSpec>(
         state: &mut BeaconState<E>,

consensus/types/src/beacon_state.rs

@@ -760,21 +760,6 @@ impl<E: EthSpec> BeaconState<E> {
         }
     }
 
-    /// Return true if the parent block was full (both beacon block and execution payload were present).
-    pub fn is_parent_block_full(&self) -> bool {
-        match self {
-            BeaconState::Base(_) | BeaconState::Altair(_) => false,
-            BeaconState::Bellatrix(_)
-            | BeaconState::Capella(_)
-            | BeaconState::Deneb(_)
-            | BeaconState::Electra(_)
-            | BeaconState::Fulu(_) => true,
-            BeaconState::Gloas(state) => {
-                state.latest_execution_payload_bid.block_hash == state.latest_block_hash
-            }
-        }
-    }
-
     /// Returns the `tree_hash_root` of the state.
     pub fn canonical_root(&mut self) -> Result<Hash256, Error> {
         self.update_tree_hash_cache()
@@ -2219,6 +2204,22 @@ impl<E: EthSpec> BeaconState<E> {
         }
     }
 
+    /// Return true if the parent block was full (both beacon block and execution payload were present).
+    pub fn is_parent_block_full(&self) -> bool {
+        match self {
+            BeaconState::Base(_) | BeaconState::Altair(_) => false,
+            // TODO(EIP-7732): check the implications of this when we get to forkchoice modifications
+            BeaconState::Bellatrix(_)
+            | BeaconState::Capella(_)
+            | BeaconState::Deneb(_)
+            | BeaconState::Electra(_)
+            | BeaconState::Fulu(_) => true,
+            BeaconState::Gloas(state) => {
+                state.latest_execution_payload_bid.block_hash == state.latest_block_hash
+            }
+        }
+    }
+
     /// Get the committee cache for some `slot`.
     ///
     /// Return an error if the cache for the slot's epoch is not initialized.