Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ja3Fingerprint supported in console but provider not updated to reflect that #197

Closed
roryscarson opened this issue Aug 3, 2023 · 3 comments
Assignees

Comments

@roryscarson
Copy link

The rule builder supports using ja3Fingerprint as an identifier
Screenshot 2023-08-03 at 15 53 00

however this is not reflected in the documentation for the site_rule and the validator throws a warning

TF Code

resource "sigsci_site_rule" "test_rule" {
  site_short_name =  SITENAME
  type            = "request"
  group_operator  = "all"
  enabled         = false
  reason          = "Testing JA3"
  expiration      = ""


  actions {
    signal = "site.testing"
    type   = "addSignal"
  }

  conditions {
    field    = "ja3Fingerprint"
    operator = "equals"
    type     = "single"
    value    = "test"
  }
}

TF Plan and Apply output

Terraform will perform the following actions:


  # sigsci_site_rule.test_rule will be updated in-place
  ~ resource "sigsci_site_rule" "test_rule" {
      ~ enabled         = true -> false
        id              = "64cbae0243b7a901d4fa054a"
      ~ reason          = "testing ja3" -> "Testing JA3"
        # (5 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.
╷
│ Warning: received "ja3Fingerprint" for conditions.field. This is not necessarily an error, but we only know about the following values. If this is a new value, please open a PR to get it added.
│ (scheme, method, path, useragent, domain, ip, responseCode, agentname, paramname, paramvalue, country, name, valueString, valueIp, signalType, value, signal, requestHeader, queryParameter, postParameter, requestCookie, responseHeader)
│
│   with sigsci_site_rule.test_rule,
│   on testing.tf line 1, in resource "sigsci_site_rule" "test_rule":
│    1: resource "sigsci_site_rule" "test_rule" {
│
│ (and one more similar warning elsewhere)
╵

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

sigsci_site_rule.test_rule: Modifying... [id=64cbae0243b7a901d4fa054a]
╷
│ Warning: received "ja3Fingerprint" for conditions.field. This is not necessarily an error, but we only know about the following values. If this is a new value, please open a PR to get it added.
│ (scheme, method, path, useragent, domain, ip, responseCode, agentname, paramname, paramvalue, country, name, valueString, valueIp, signalType, value, signal, requestHeader, queryParameter, postParameter, requestCookie, responseHeader)
│
│   with sigsci_site_rule.test_rule,
│   on testing.tf line 1, in resource "sigsci_site_rule" "test_rule":
│    1: resource "sigsci_site_rule" "test_rule" {
│
╵
Releasing state lock. This may take a few moments...

Apply complete! Resources: 0 added, 8 changed, 0 destroyed.
@daniel-corbett
Copy link
Collaborator

Hi @roryscarson - this is currently a beta feature so is not available yet to all customers, which is why it has not been added into the terraform provider. When the feature graduates to GA we will be sure to update the terraform provider.

@daniel-corbett
Copy link
Collaborator

Hi @roryscarson - ja3Fingerprint has been merged and it will come in the next release. We will probably issue a new release soon after #214 is merged.

@daniel-corbett daniel-corbett self-assigned this Mar 15, 2024
@daniel-corbett
Copy link
Collaborator

This is supported as of version 2.1.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants