Fix layout issues with group call drawer

Author: elaine-signal

Signal/Calls/UserInterface/CallDrawerSheet.swift

@@ -364,6 +364,11 @@ class CallDrawerSheet: InteractiveSheetViewController {
     override func heightDidChange(to height: InteractiveSheetViewController.SheetHeight) {
         switch height {
         case .min:
+            guard UIView.inheritedAnimationDuration > 0 else {
+                changesForSnapToMin()
+                break
+            }
+
             let currentHeight = switch lastKnownHeight {
             case .min:
                 self.minimizedHeight
@@ -433,6 +438,11 @@ class CallDrawerSheet: InteractiveSheetViewController {
                 changesForSnapToMax()
             }
         case .max:
+            guard UIView.inheritedAnimationDuration > 0 else {
+                changesForSnapToMax()
+                break
+            }
+
             let currentHeight = switch lastKnownHeight {
             case .min:
                 self.minimizedHeight
@@ -584,7 +594,7 @@ extension CallDrawerSheet {
     }
 
     func isPresentingCallInfo() -> Bool {
-        return self.presentingViewController != nil && tableView.alpha == 1
+        return self.presentingViewController != nil && tableViewContainer.alpha == 1
     }
 
     func isCrossFading() -> Bool {

Signal/Calls/UserInterface/GroupCallViewController.swift

@@ -810,7 +810,7 @@ class GroupCallViewController: UIViewController {
         if shouldRepositionBottomVStack {
             switch bottomSheetStateManager.bottomSheetState {
             case .callControlsAndOverflow, .callControls, .callInfo, .transitioning:
-                yMax = size.height - bottomSheet.sheetHeight - 16
+                yMax = size.height - bottomSheet.minimizedHeight - 16
             case .hidden:
                 yMax = size.height - 32
             }
@@ -1015,11 +1015,11 @@ class GroupCallViewController: UIViewController {
     }
 
     private var callControlsOverflowBottomConstraintConstant: CGFloat {
-        -self.bottomSheet.sheetHeight - 12
+        -self.bottomSheet.minimizedHeight - 12
     }
 
     private var callControlsConfirmationToastContainerViewBottomConstraintConstant: CGFloat {
-        return -self.bottomSheet.sheetHeight - 16
+        return -self.bottomSheet.minimizedHeight - 16
     }
 
     private func callControlDisplayStateDidChange(

Signal/Calls/UserInterface/IndividualCallViewController.swift

@@ -340,7 +340,7 @@ class IndividualCallViewController: OWSViewController, IndividualCallObserver {
 
     private var callControlsConfirmationToastContainerViewBottomConstraint: NSLayoutConstraint?
     private var callControlsConfirmationToastContainerViewBottomConstraintConstant: CGFloat {
-        return -self.bottomSheet.sheetHeight - 16
+        return -self.bottomSheet.minimizedHeight - 16
     }
 
     private func presentBottomSheet(_ animated: Bool) {

SignalUI/ViewControllers/InteractiveSheetViewController.swift

@@ -42,14 +42,6 @@ open class InteractiveSheetViewController: OWSViewController {
         return (sheetContainerView as? UIVisualEffectView)?.contentView ?? sheetContainerView
     }
 
-    // Do yourself a favor and do not expose the sheet view and try to
-    // constrain to it from another ViewController, even if said
-    // ViewController is presenting this one.
-    public var sheetHeight: CGFloat {
-        let sheet = (sheetContainerView as? UIVisualEffectView)?.contentView ?? sheetContainerView
-        return sheet.height
-    }
-
     private let sheetStackView: UIStackView = {
         let view = UIStackView()
         view.axis = .vertical