Skip to content

Commit dbed8b5

Browse files
Merge branch 'charlesmchen/decryptDeduplicationLogging' into release/5.20.4
2 parents d37a8fa + e88215c commit dbed8b5

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

SignalServiceKit/src/Messages/MessageProcessor.swift

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -540,6 +540,9 @@ class MessageDecryptDeduplicationRecord: Codable, FetchableRecord, PersistableRe
540540
cull(latestServiceTimestamp: serviceTimestamp, transaction: transaction)
541541
}
542542

543+
if DebugFlags.internalLogging {
544+
Logger.info("Proceeding with serviceTimestamp: \(serviceTimestamp), serverGuid: \(serverGuid)")
545+
}
543546
return .nonDuplicate
544547
} catch {
545548
owsFailDebug("Error: \(error)")

SignalServiceKit/src/Messages/OWSMessageDecrypter.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,7 @@ public class OWSMessageDecrypter: OWSMessageHandler {
290290
contentHint: SealedSenderContentHint,
291291
transaction: SDSAnyWriteTransaction
292292
) -> Error {
293-
let logString = "Error while decrypting \(Self.description(forEnvelopeType: envelope)) message: \(error)"
293+
let logString = "Error while decrypting \(Self.description(for: envelope)), error: \(error)"
294294

295295
if case SignalError.duplicatedMessage(_) = error {
296296
Logger.info(logString)

SignalServiceKit/src/Messages/OWSMessageHandler.m

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,10 +55,13 @@ + (NSString *)descriptionForEnvelope:(SSKProtoEnvelope *)envelope
5555
{
5656
OWSAssertDebug(envelope != nil);
5757

58-
return [NSString stringWithFormat:@"<Envelope type: %@, source: %@, timestamp: %llu content.length: %lu />",
58+
return [NSString stringWithFormat:@"<Envelope type: %@, source: %@, timestamp: %llu, serverTimestamp: %llu, "
59+
@"serverGuid: %@, content.length: %lu />",
5960
[self descriptionForEnvelopeType:envelope],
6061
envelopeAddress(envelope),
6162
envelope.timestamp,
63+
envelope.serverTimestamp,
64+
envelope.serverGuid,
6265
(unsigned long)envelope.content.length];
6366
}
6467

0 commit comments

Comments
 (0)