Fix version comparisons of different lengths

Author: max-signal

SignalServiceKit/src/Util/AppVersion.swift

@@ -196,8 +196,8 @@ public class AppVersion {
 
         let largestCount = max(lhsComponents.count, rhsComponents.count)
         for index in (0..<largestCount) {
-            let lhsComponent = parseVersionComponent(lhsComponents[index])
-            let rhsComponent = parseVersionComponent(rhsComponents[index])
+            let lhsComponent = parseVersionComponent(lhsComponents[safe: index])
+            let rhsComponent = parseVersionComponent(rhsComponents[safe: index])
             if lhsComponent != rhsComponent {
                 return (lhsComponent < rhsComponent) ? .orderedAscending : .orderedDescending
             }

SignalServiceKit/tests/Util/AppVersionTests.swift

@@ -7,7 +7,7 @@ import Foundation
 import XCTest
 @testable import SignalServiceKit
 
-final class AppVersionTests: XCTest {
+final class AppVersionTests: XCTestCase {
     func testVersionComparisons() {
         let testCases: [(String, String, ComparisonResult)] = [
             ("0", "0", .orderedSame),