Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: title and meta tags for react-ui.dev #95

Open
mbj36 opened this issue May 30, 2020 · 6 comments · May be fixed by #96
Open

docs: title and meta tags for react-ui.dev #95

mbj36 opened this issue May 30, 2020 · 6 comments · May be fixed by #96
Labels
good first issue Good for newcomers

Comments

@mbj36
Copy link
Contributor

mbj36 commented May 30, 2020

For better SEO, we should add title and meta tags, currently it doesn't show up in Google Search, had to go to Github profile and navigate from there

@siddharthkp siddharthkp added the good first issue Good for newcomers label Jun 1, 2020
@siddharthkp
Copy link
Owner

That's a good one, would you like to pick it up?

@Avi98
Copy link

Avi98 commented Jun 1, 2020

@siddharthkp if no one is looking into it can pick it up

@siddharthkp
Copy link
Owner

I'd wait for @mbj36 to reply. If he doesn't want to pick it, it's all yours

@mbj36
Copy link
Contributor Author

mbj36 commented Jun 2, 2020

@Avi98 Please take up, my github notification messed up, so couldn't reply earlier.

@Avi98
Copy link

Avi98 commented Jun 3, 2020

@siddharthkp , this is how I was thinking of implementing it, using a third party lib, and the creating a component at the called Head root level which will contain all the meta tags

@Avi98 Avi98 linked a pull request Jun 4, 2020 that will close this issue
@siddharthkp
Copy link
Owner

Helmet is a great choice 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants