From d3b7041028de07625c7c2f44b14c93e37a2e0a6a Mon Sep 17 00:00:00 2001 From: YYTVicky <61596169+YYTVicky@users.noreply.github.com> Date: Thu, 5 Mar 2020 23:18:35 -0800 Subject: [PATCH 1/2] Update AuthenticateCommand.java --- .../binlog/network/protocol/command/AuthenticateCommand.java | 1 + 1 file changed, 1 insertion(+) diff --git a/src/main/java/com/github/shyiko/mysql/binlog/network/protocol/command/AuthenticateCommand.java b/src/main/java/com/github/shyiko/mysql/binlog/network/protocol/command/AuthenticateCommand.java index a045fe24..9f31398d 100644 --- a/src/main/java/com/github/shyiko/mysql/binlog/network/protocol/command/AuthenticateCommand.java +++ b/src/main/java/com/github/shyiko/mysql/binlog/network/protocol/command/AuthenticateCommand.java @@ -82,6 +82,7 @@ public byte[] toByteArray() throws IOException { public static byte[] passwordCompatibleWithMySQL411(String password, String salt) { MessageDigest sha; try { + // sha-1 is not secure sha = MessageDigest.getInstance("SHA-1"); } catch (NoSuchAlgorithmException e) { throw new RuntimeException(e); From cea8c507bd62f4d199e061de8dfe9a98ea4b4c56 Mon Sep 17 00:00:00 2001 From: YYTVicky <61596169+YYTVicky@users.noreply.github.com> Date: Thu, 30 Apr 2020 00:03:26 -0400 Subject: [PATCH 2/2] Update AuthenticateCommand.java --- .../binlog/network/protocol/command/AuthenticateCommand.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/main/java/com/github/shyiko/mysql/binlog/network/protocol/command/AuthenticateCommand.java b/src/main/java/com/github/shyiko/mysql/binlog/network/protocol/command/AuthenticateCommand.java index 9f31398d..0e014a1a 100644 --- a/src/main/java/com/github/shyiko/mysql/binlog/network/protocol/command/AuthenticateCommand.java +++ b/src/main/java/com/github/shyiko/mysql/binlog/network/protocol/command/AuthenticateCommand.java @@ -82,7 +82,9 @@ public byte[] toByteArray() throws IOException { public static byte[] passwordCompatibleWithMySQL411(String password, String salt) { MessageDigest sha; try { - // sha-1 is not secure + /** + * recommend sha = MessageDigest.getInstance("SHA-512"); + */ sha = MessageDigest.getInstance("SHA-1"); } catch (NoSuchAlgorithmException e) { throw new RuntimeException(e);