Skip to content

Why not support pull instead of push in BinaryLogClient ? #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wenerme opened this issue Apr 28, 2015 · 1 comment
Closed

Why not support pull instead of push in BinaryLogClient ? #42

wenerme opened this issue Apr 28, 2015 · 1 comment

Comments

@wenerme
Copy link

wenerme commented Apr 28, 2015

This may solve a lot of problem, like #15 ,for currently Listener, I have to use a BlockingQueue to implement some pull style code.

@shyiko
Copy link
Owner

shyiko commented Apr 28, 2015

By #15 I'll assume #32 (as former isn't really related).

In our case we needed to respond to the events as soon as they where arriving and the lion share of the time was spent on IO/deserialization rather than on "processing logic" so synchronous, push implementation was "just enough". Given different circumstances/requirements I might gone with NIO and pull approach but at that time it just wasn't important. Plus, one can always implement a different client leveraging everything else from the project. There isn't really anything that is somehow dependent on BinaryLogClient internals. Providing a different implementation should be relatively easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants