fix: phpstan deprecation (#580)

Author: mstegmeyer

phpstan.neon.dist

@@ -88,6 +88,10 @@ parameters:
             identifier: method.deprecated
             message: '#__construct.*Shopware\\Core\\Framework\\DataAbstractionLayer\\EntityDefinition.*#'
 
+        - # 6.8 deprecation
+            identifier: method.deprecated
+            message: '#arameter \$silent will be added in v6\.8\.0.*#'
+
         - # 6.8 deprecation - only type change
             identifier: method.deprecated
             message: '#(setActiveBillingAddress|setActiveShippingAddress).*Shopware\\Core\\Checkout\\Customer\\CustomerEntity.*#'

src/Checkout/Order/Shipping/MessageQueue/ShippingInformationMessageHandler.php

@@ -150,7 +150,7 @@ private function handleInvalidCarrierException(PayPalApiException $e, Tracker &$
     private function trimTrackers(array $trackers): array
     {
         return \array_filter(\array_map(
-            fn (string $tracker) => \mb_substr($tracker, 0, Tracker::MAX_LENGTH_TRACKING_NUMBER),
+            static fn (string $tracker) => \mb_substr($tracker, 0, Tracker::MAX_LENGTH_TRACKING_NUMBER),
             $trackers
         ));
     }

src/Checkout/PUI/Service/PUICustomerDataService.php

@@ -66,7 +66,7 @@ private function getBirthday(DataBag $dataBag): ?\DateTimeInterface
     {
         $birthdayArray = $dataBag->get(self::PUI_CUSTOMER_DATA_BIRTHDAY);
 
-        if (!($birthdayArray instanceof DataBag)) {
+        if (!$birthdayArray instanceof DataBag) {
             return null;
         }
 

src/Checkout/Payment/Service/VaultTokenService.php

@@ -68,7 +68,7 @@ public function getAvailableToken(PaymentTransactionStruct $struct, OrderTransac
         if ($subscriptions = $this->getSubscriptions($struct)) {
             $customFieldKey = $this->getSubscriptionCustomFieldKey($orderTransaction->getPaymentMethodId());
             $tokenIds = \array_unique(\array_values(
-                $subscriptions->fmap(fn (SubscriptionEntity $subscription): string => (string) $subscription->getCustomFieldsValue($customFieldKey))
+                $subscriptions->fmap(static fn (SubscriptionEntity $subscription): string => (string) $subscription->getCustomFieldsValue($customFieldKey))
             ));
 
             if (\count($tokenIds) > 1) {

src/DevOps/Command/LocaleScraperCommand.php

@@ -36,7 +36,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         $crawler = new Crawler($html);
         $locales = [];
 
-        $crawler->filter('table tbody tr')->each(function (Crawler $row) use (&$locales): void {
+        $crawler->filter('table tbody tr')->each(static function (Crawler $row) use (&$locales): void {
             $columns = $row->filter('td');
             if ($columns->count() < 3) {
                 return;

src/Pos/Sync/Context/InventoryContextFactory.php

@@ -98,7 +98,7 @@ public function updateLocal(InventoryContext $inventoryContext): void
             $criteria->addFilter(new EqualsAnyFilter('productId', $productIds));
         }
         $inventory = $this->inventoryRepository->search($criteria, $inventoryContext->getContext())->getEntities();
-        if (!($inventory instanceof PosSalesChannelInventoryCollection)) {
+        if (!$inventory instanceof PosSalesChannelInventoryCollection) {
             throw new EntityRepositoryNotFoundException('swag_paypal_pos_sales_channel_inventory');
         }
 

src/Pos/Sync/Context/ProductContextFactory.php

@@ -42,15 +42,15 @@ public function getContext(SalesChannelEntity $salesChannel, Context $context, ?
         $posProductCollection = $this->getPosProductCollection(
             $salesChannel->getId(),
             $context,
-            $productCollection !== null ? $productCollection->fmap(function (ProductEntity $product) {
+            $productCollection !== null ? $productCollection->fmap(static function (ProductEntity $product) {
                 return $product->getId();
             }) : null
         );
 
         $posMediaCollection = $this->getPosMediaCollection(
             $salesChannel->getId(),
             $context,
-            $productCollection !== null ? $productCollection->fmap(function (ProductEntity $product) {
+            $productCollection !== null ? $productCollection->fmap(static function (ProductEntity $product) {
                 $cover = $product->getCover();
 
                 return $cover !== null ? $cover->getMediaId() : null;

src/Pos/Sync/Product/Util/ProductGroupingCollection.php

@@ -21,7 +21,7 @@ class ProductGroupingCollection extends Collection
     public function addProducts(ProductCollection $products): void
     {
         foreach ($products as $product) {
-            if (!($product instanceof SalesChannelProductEntity)) {
+            if (!$product instanceof SalesChannelProductEntity) {
                 continue;
             }
 

src/Util/Lifecycle/Method/PaymentMethodDataRegistry.php

@@ -93,7 +93,7 @@ public function getEntityFromData(AbstractMethodData $method, Context $context):
     public function getPaymentHandlers(): array
     {
         return \array_map(
-            fn (AbstractMethodData $method) => $method->getHandler(),
+            static fn (AbstractMethodData $method) => $method->getHandler(),
             $this->getPaymentMethods()
         );
     }

src/Util/Lifecycle/State/PosStateService.php

@@ -99,7 +99,7 @@ public function checkPosSalesChannels(Context $context): void
         $result = $this->salesChannelRepository->search($criteria, $context);
 
         if ($result->getTotal() > 0) {
-            $names = $result->getEntities()->map(function (SalesChannelEntity $item): string {
+            $names = $result->getEntities()->map(static function (SalesChannelEntity $item): string {
                 return (string) $item->getName();
             });