Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seems to rely on lodash / underscore in app code for some reason #35

Open
alexspeller opened this issue Oct 22, 2015 · 0 comments
Open

Seems to rely on lodash / underscore in app code for some reason #35

alexspeller opened this issue Oct 22, 2015 · 0 comments

Comments

@alexspeller
Copy link

Seems like the addon is relying on underscore being present, but it's not explicitly imported by index.js - would it make sense to not use _ for this one method in the addon code so as to not add another dependency?

https://github.com/shaunc/ember-grid/blob/master/addon/components/eg-column/component.js#L40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexspeller