-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
firefox is broken #32
Comments
Any particular version to test on? |
@lcpriest we're in the middle of refactoring the way scrolling is done, so please test on any browsers you have available. If you can fix any scroll issues with a PR without breaking them in other browsers you'll be a hero. y-scroll should only scroll body section Both scrollbars should only be visible if scrolling in that direction is required |
additional spec - header and footer heights should autosize to contents. Body should fill the remaining space. |
In your Ember London talk, you had a demo app already spun up - is that available for testing? Or should I build my own example app. |
it's the test dummy app.
|
it's also linked from the readme page on github, but we only push that when it's working so it's out of date! |
Just pushed a fix for firefox w/ native-scroll mode (which is turned on on macs and phones). Once we confirm that firefox works in windows/firefox we can close this issue. |
Will spin up a windows machine later today.... |
Sorry I can't help. Doing a 22 hour day for a client including 10
hours of driving...
|
ok ... thought I wouldn't get to it but pushed something for windows/chrome. Hope you made it home safely! |
YAY!!! It works. (windows+chrome) |
Wow - Firefox, go home - you're drunk. Firebug's log limit has been reached. 0 entries not shown. Preferences |
... sigh ... it seems we are pushing the limits of browser compatibility... I asked testem whether I could set windows tests on virtual machines -- but no response yet. Maybe I'll try to figure out how to do this on my own using docker, as it seems that, even when we get our test suite in shape, passing in phantomjs doesn't necessarily translate into passing in browser X. |
tracking firefox problem separately from -- #25
Firefox display is broken currently.
It seems to start working when heights are set explicitly -- for me. You say you don't see anything in DOM at all? Is there a javascript error?
The text was updated successfully, but these errors were encountered: