Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firefox is broken #32

Open
shaunc opened this issue Sep 14, 2015 · 14 comments
Open

firefox is broken #32

shaunc opened this issue Sep 14, 2015 · 14 comments

Comments

@shaunc
Copy link
Owner

shaunc commented Sep 14, 2015

tracking firefox problem separately from -- #25
Firefox display is broken currently.

It seems to start working when heights are set explicitly -- for me. You say you don't see anything in DOM at all? Is there a javascript error?

@lcpriest
Copy link

Any particular version to test on?

@BryanCrotaz
Copy link
Collaborator

@lcpriest we're in the middle of refactoring the way scrolling is done, so please test on any browsers you have available. If you can fix any scroll issues with a PR without breaking them in other browsers you'll be a hero.

y-scroll should only scroll body section
x-scroll should scroll header, body and footer together

Both scrollbars should only be visible if scrolling in that direction is required

@BryanCrotaz
Copy link
Collaborator

additional spec - header and footer heights should autosize to contents. Body should fill the remaining space.

@lcpriest
Copy link

In your Ember London talk, you had a demo app already spun up - is that available for testing? Or should I build my own example app.

@BryanCrotaz
Copy link
Collaborator

it's the test dummy app.

ember serve

@BryanCrotaz
Copy link
Collaborator

it's also linked from the readme page on github, but we only push that when it's working so it's out of date!

@shaunc
Copy link
Owner Author

shaunc commented Sep 15, 2015

Just pushed a fix for firefox w/ native-scroll mode (which is turned on on macs and phones). Once we confirm that firefox works in windows/firefox we can close this issue.

@BryanCrotaz
Copy link
Collaborator

Chrome on Windows is broken. No y-scrollbar and column widths broken in "scroll columns"

image

image

image

@shaunc
Copy link
Owner Author

shaunc commented Sep 16, 2015

Will spin up a windows machine later today....

@BryanCrotaz
Copy link
Collaborator

BryanCrotaz commented Sep 16, 2015 via email

@shaunc
Copy link
Owner Author

shaunc commented Sep 17, 2015

ok ... thought I wouldn't get to it but pushed something for windows/chrome.

Hope you made it home safely!

@BryanCrotaz
Copy link
Collaborator

YAY!!! It works. (windows+chrome)

@BryanCrotaz
Copy link
Collaborator

Wow - Firefox, go home - you're drunk.

Firebug's log limit has been reached. 0 entries not shown. Preferences
this.window.console.error.bind is not a function
[Break On This Error] error: this.window.console.error.bind(this.window.console)
livere...ipver=1 (line 301)
Accessors not supported!
[Break On This Error] if('get' in Attributes || 'set' in...ypeError('Accessors not supported!');
vendor.js (line 1456)
Could not find module ember imported from dummy/app
[Break On This Error] throw new Error('Could not find ... 'imported from' + origin + '`');

@shaunc
Copy link
Owner Author

shaunc commented Sep 18, 2015

... sigh ... it seems we are pushing the limits of browser compatibility... I asked testem whether I could set windows tests on virtual machines -- but no response yet.

Maybe I'll try to figure out how to do this on my own using docker, as it seems that, even when we get our test suite in shape, passing in phantomjs doesn't necessarily translate into passing in browser X.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants