unserialize(): Argument #1 ($data) must be of type string, bool given at BookmarkIO.php line 92

[landure]

I've just encountered this issue out of nowhere after successfully adding a bookmark, in latest docker image:

An unexpected error happened, and the error template could not be displayed.

unserialize(): Argument #1 ($data) must be of type string, bool given
/var/www/shaarli/application/bookmark/BookmarkIO.php92
#0 /var/www/shaarli/application/bookmark/BookmarkIO.php(92): unserialize()
#1 /var/www/shaarli/application/bookmark/BookmarkFileService.php(80): Shaarli\Bookmark\BookmarkIO->read()
#2 /var/www/shaarli/application/container/ContainerBuilder.php(96): Shaarli\Bookmark\BookmarkFileService->__construct()
#3 /var/www/shaarli/vendor/pimple/pimple/src/Pimple/Container.php(122): Shaarli\Container\ContainerBuilder->Shaarli\Container\{closure}()
#4 /var/www/shaarli/vendor/slim/slim/Slim/Container.php(109): Pimple\Container->offsetGet()
#5 /var/www/shaarli/vendor/slim/slim/Slim/Container.php(164): Slim\Container->get()
#6 /var/www/shaarli/application/container/ContainerBuilder.php(114): Slim\Container->__get()
#7 /var/www/shaarli/vendor/pimple/pimple/src/Pimple/Container.php(122): Shaarli\Container\ContainerBuilder->Shaarli\Container\{closure}()
#8 /var/www/shaarli/vendor/slim/slim/Slim/Container.php(109): Pimple\Container->offsetGet()
#9 /var/www/shaarli/vendor/slim/slim/Slim/Container.php(164): Slim\Container->get()
#10 /var/www/shaarli/application/front/controller/visitor/ErrorController.php(20): Slim\Container->__get()
#11 [internal function]: Shaarli\Front\Controller\Visitor\ErrorController->__invoke()
#12 /var/www/shaarli/vendor/slim/slim/Slim/App.php(728): call_user_func_array()
#13 /var/www/shaarli/vendor/slim/slim/Slim/App.php(396): Slim\App->handlePhpError()
#14 /var/www/shaarli/vendor/slim/slim/Slim/App.php(297): Slim\App->process()
#15 /var/www/shaarli/index.php(202): Slim\App->run()
#16 {main}

the code is:

        $links = unserialize(gzinflate(base64_decode(
            substr($content, strlen(self::$phpPrefix), -strlen(self::$phpSuffix))
        )));

It would gain to be spit in 4 different lines for clarity and error checking.

[landure]

A quick rewrite of the code would be:

        $baseSixtyFourContents = substr(
            $content,
            strlen(self::$phpPrefix),
            -strlen(self::$phpSuffix),
        );

        $gzContents = base64_decode($baseSixtyFourContents);

        if (false === $gzContents) {
            throw new NotWritableDataStoreException($this->datastore);
        }

        $deflatedContents = gzinflate($gzContents);

        if (false === $deflatedContents) {
            throw new NotWritableDataStoreException($this->datastore);
        }

        // Note that gzinflate is faster than gzuncompress.
        // See: http://www.php.net/manual/en/function.gzdeflate.php#96439
        $links = unserialize($deflatedContents);

[nodiscc]

Same as #2156, we cannot fix the problem if we don't know what the problem is in the first place. I can't reproduce this on demo.shaarli.org or on my own instance.

Please provide webserver/PHP/system logs at the time of the crash.

[landure]

I've lost the logs since. I can't provide more information. The issue was triggered by an empty datastore.php.

[nodiscc]

Caused by #2156

[landure]

Note that implementing my proposed change would ensure that NotWritableDataStoreException is thrown in case of issue. The user would not be displayed a PHP error. The exception shoult may be NotReadableDataStoreException