Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot choose Google Account to sign in with from sign-on page #441

Open
nickvisut opened this issue Oct 11, 2024 · 2 comments
Open

Cannot choose Google Account to sign in with from sign-on page #441

nickvisut opened this issue Oct 11, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@nickvisut
Copy link
Contributor

nickvisut commented Oct 11, 2024

ACTUAL

When a user navigates to the Compass sign-in page, when they click "Sign in with Google", the app automatically brings them to the Compass home page if they are already signed in to a Google Account.

EXPECTED

When a user navigates to the sign-in page, when they click "Sign in with Google", the app ought to pop up a Google Sign In interstitial that allows the user to select a Google Account to use for authentication. Presumably, any additional flow for Google (allowing permissions etc) ought to occur as well. Then and only then should they be redirected to the Compass home page.

NOTE: We need to investigate what the app is checking for wrt Google Account auth and why it appears to automatically make use of whatever Google Account may already be signed in.

NOTE # 2: Need to double check whether or not this is expected behavior when only one Google Account is already signed in and what happens when no Google Account is signed in.

NOTE # 3: This seems to happen when only one Google account logs in. If multiple Google accounts log in, the behavior seems to be as expected.

@nickvisut nickvisut added the bug Something isn't working label Oct 11, 2024
@nickvisut
Copy link
Contributor Author

cc @canjalal and also @thomhickey b/c you're looking into auth

@mrabbitt
Copy link
Contributor

mrabbitt commented Oct 12, 2024

@nickvisut I think I found a way to fix this a way back, but I was unsure what the expected behavior should be from a PM perspective, so I left it in draft to bring up later: #400

I'm not sure if this fully addresses your concerns though...let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Ready for Dev
Development

No branches or pull requests

2 participants