Added identifier to constructor. Dropped unneeded parent constructor calls. Added LICENSE. Minor micro optimizations. Outfactored Swagger definitions to own repo

Author: matthiez

.idea/.gitignore

@@ -0,0 +1,21 @@
+MIT License
+
+Copyright (c) 2019-present sms77 e.K.
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.

.idea/modules.xml

@@ -1,12 +1,10 @@
 {
-  "name": "sms77/api",
-  "description": "A simple PHP library for making CURL requests to sms77.io gateway.",
-  "type": "library",
-  "license": "MIT",
   "authors": [
     {
-      "name": "Sms77",
-      "email": "info@sms77.io"
+      "name": "André Matthies",
+      "email": "a.matthies@sms77.io",
+      "homepage": "http://www.sms77.io",
+      "role": "Developer"
     }
   ],
   "autoload": {
@@ -20,14 +18,32 @@
       "Sms77\\Tests\\": "tests/"
     }
   },
+  "description": "A simple PHP library for making CURL requests to sms77.io gateway.",
+  "homepage": "https://github.com/sms77io/php-api",
+  "keywords": [
+    "2fa",
+    "sms",
+    "gateway"
+  ],
+  "license": "MIT",
+  "name": "sms77/api",
   "require": {
+    "php": ">=5.6.0",
     "ext-ctype": "*",
-    "ext-curl": "*"
+    "ext-curl": "*",
+    "ext-mbstring": "*"
   },
   "require-dev": {
     "phpunit/phpunit": "^8",
     "ext-soap": "*",
     "ext-simplexml": "*",
     "ext-json": "*"
-  }
+  },
+  "support": {
+    "email": "support@sms77.io",
+    "rss": "https://www.sms77.io/de/feed/",
+    "source": "https://github.com/sms77io/php-api",
+    "docs": "https://github.com/sms77io/php-api"
+  },
+  "type": "library"
 }

.idea/php.xml

@@ -15,108 +15,113 @@ class Client
     /* @var string $apiKey */
     private $apiKey;
 
+    /* @var string $sendWith */
+    private $sendWith;
+
     const BASE_URI = 'https://gateway.sms77.io/api';
 
-    public function __construct($apiKey)
+    public function __construct($apiKey, $sendWith = 'php-api')
     {
         $this->apiKey = $apiKey;
+        $this->sendWith = $sendWith;
     }
 
-    function balance()
+    public function balance()
     {
-        return $this->request("balance", $this->buildOptions([]));
+        return $this->request('balance', $this->buildOptions([]));
     }
 
-    function contacts($action, array $extra = [])
+    public function contacts($action, array $extra = [])
     {
         $options = $this->buildOptions([
-            "action" => $action,
+            'action' => $action,
         ], $extra);
 
         (new ContactsValidator($options))->validate();
 
-        return $this->request("contacts", $options);
+        return $this->request('contacts', $options);
     }
 
-    function lookup($type, $number, array $extra = [])
+    public function lookup($type, $number, array $extra = [])
     {
         $options = $this->buildOptions([
-            "type" => $type,
-            "number" => $number,
+            'type' => $type,
+            'number' => $number,
         ], $extra);
 
         (new LookupValidator($options))->validate();
 
-        return $this->request("lookup", $options);
+        return $this->request('lookup', $options);
     }
 
-    function pricing(array $extra = [])
+    public function pricing(array $extra = [])
     {
         $options = $this->buildOptions([], $extra);
 
         (new PricingValidator($options))->validate();
 
-        return $this->request("pricing", $options);
+        return $this->request('pricing', $options);
     }
 
-    function sms($to, $text, array $extra = [])
+    public function sms($to, $text, array $extra = [])
     {
         $options = $this->buildOptions([
-            "to" => $to,
-            "text" => $text
+            'to' => $to,
+            'text' => $text
         ], $extra);
 
         (new SmsValidator($options))->validate();
 
-        return $this->request("sms", $options);
+        return $this->request('sms', $options);
     }
 
-    function status($msgId)
+    public function status($msgId)
     {
         $options = $this->buildOptions([
-            "msg_id" => $msgId,
+            'msg_id' => $msgId,
         ]);
 
         (new StatusValidator($options))->validate();
 
-        return $this->request("status", $options);
+        return $this->request('status', $options);
     }
 
-    function validateForVoice($number, array $extra = [])
+    public function validateForVoice($number, array $extra = [])
     {
         $options = $this->buildOptions([
-            "number" => $number,
+            'number' => $number,
         ], $extra);
 
         (new ValidateForVoiceValidator($options))->validate();
 
-        return $this->request("validate_for_voice", $options);
+        return $this->request('validate_for_voice', $options);
     }
 
-    function voice($to, $text, array $extra = [])
+    public function voice($to, $text, array $extra = [])
     {
         $options = $this->buildOptions([
-            "to" => $to,
-            "text" => $text
+            'to' => $to,
+            'text' => $text
         ], $extra);
 
         (new VoiceValidator($options))->validate();
 
-        return $this->request("voice", $options);
+        return $this->request('voice', $options);
     }
 
     private function buildOptions(array $required, array $extra = [])
     {
         $required = array_merge($required, [
-            "p" => $this->apiKey
+            'p' => $this->apiKey,
+            'sendwith' => '' === $this->sendWith ? 'unknown' : $this->sendWith
         ]);
 
         return array_merge($required, $extra);
     }
 
     private function request($path, $options = [])
     {
-        $curl_get_contents = function ($url) {
+        $curl_get_contents = static function ($url) {
             $ch = curl_init();
             curl_setopt($ch, CURLOPT_URL, $url);
             curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);
@@ -125,6 +130,6 @@ private function request($path, $options = [])
             return $output;
         };
 
-        return $curl_get_contents(self::BASE_URI . "/" . $path . "?" . http_build_query($options));
+        return $curl_get_contents(self::BASE_URI . '/' . $path . '?' . http_build_query($options));
     }
 }

.idea/sms77-api.iml

@@ -10,30 +10,30 @@ class BaseValidator
     /* @var array $parameters */
     protected $parameters;
 
-    protected $allowedTypes = ["direct", "economy"];
-
-    function __construct(array $parameters)
+    public function __construct(array $parameters)
     {
         $this->parameters = $parameters;
 
-        if (!isset($parameters["p"])) {
-            throw new InvalidRequiredArgumentException("p is missing.");
+        if (!isset($parameters['p'])) {
+            throw new InvalidRequiredArgumentException('p is missing.');
         }
     }
 
     protected function isValidBool($data)
     {
-        return 1 == $data || 0 == $data;
+        $data = (int)$data;
+
+        return 1 === $data || 0 === $data;
     }
 
     protected function throwOnOptionalBadType()
     {
-        $types = ["direct", "economy"];
+        $types = ['direct', 'economy'];
 
-        $type = isset($this->parameters["type"]) ? $this->parameters["type"] : null;
+        $type = isset($this->parameters['type']) ? $this->parameters['type'] : null;
 
-        if (null !== $type && !in_array($type, $types)) {
-            throw new InvalidOptionalArgumentException("type has invalid value $type. Allowed values are: " . join(",", $types) . ".");
+        if (null !== $type && !in_array($type, $types, true)) {
+            throw new InvalidOptionalArgumentException("type has invalid value $type. Allowed values are: " . implode(',', $types) . '.');
         }
     }