Fix compiler warnings due to incorrect drop() calls

Latest rustc warns about drop() calls used on Copy types
and drop() calls where a reference is passed instead of value.

Signed-off-by: Mukilan Thiyagarajan <[email protected]>

Author: mukilan

src/platform/macos/mod.rs

@@ -802,7 +802,7 @@ pub struct OsIpcOneShotServer {
 
 impl Drop for OsIpcOneShotServer {
     fn drop(&mut self) {
-        drop(OsIpcReceiver::unregister_global_name(mem::replace(&mut self.name, String::new())));
+        let _ = OsIpcReceiver::unregister_global_name(mem::replace(&mut self.name, String::new()));
     }
 }
 

src/test.rs

@@ -384,7 +384,7 @@ fn router_drops_callbacks_on_sender_shutdown() {
     let dropper = Dropper { sender: drop_tx };
 
     let router = RouterProxy::new();
-    router.add_route(rx0.to_opaque(), Box::new(move |_| drop(&dropper)));
+    router.add_route(rx0.to_opaque(), Box::new(move |_| { let _ = dropper; }));
     drop(tx0);
     assert_eq!(drop_rx.recv(), Ok(42));
 }
@@ -406,7 +406,7 @@ fn router_drops_callbacks_on_cloned_sender_shutdown() {
     let dropper = Dropper { sender: drop_tx };
 
     let router = RouterProxy::new();
-    router.add_route(rx0.to_opaque(), Box::new(move |_| drop(&dropper)));
+    router.add_route(rx0.to_opaque(), Box::new(move |_| { let _ = dropper; }));
     let txs = vec![tx0.clone(), tx0.clone(), tx0.clone()];
     drop(txs);
     drop(tx0);