Merge branch '7.1'

# Conflicts:
#	Orm/Xtensive.Orm/Tuples/Packed/TupleLayout.cs
#	Version.props

Author: alex-kulakov

ChangeLog/6.0.14_Z_Final.txt

@@ -0,0 +1,9 @@
+[main] Addressed issue of not visiting grouping expression correctly which appeared in previous version
+[main] Addressed certain issues of incorrect query optimization when it contains multiple In() calls
+[main] In addition to previous version, more cases of incorrect join type usage addressed
+[firebird] Updated client library package to version 6.7.0
+[mysql] Updated client library package to version  6.10.9
+[oracle] Updated client library package to version 2.18.151
+[postgresql] Updated Npgsql package to version 4.0.17 which patches some vulnerablity issues
+[sqlserver] Updated client library package to version 4.8.6
+[sqlite] Updated client library package to version 1.0.119

ChangeLog/7.0.6_Z_Final.txt

@@ -0,0 +1,3 @@
+[main] Addressed issue of not visiting grouping expression correctly which appeared in previous version
+[mysql] Updated client library package to version 8.0.31
+[postgresql] Updated client library package to version 4.1.14

ChangeLog/7.1.3_Z_Final.txt

@@ -0,0 +1,5 @@
+[main] Addressed race condition issue with TranslatorState.NonVisitableExpressions
+[main] Improved working with nullable enum constants in queries
+[main] Improved compatibility of .ToListAsync/.ToArrayAsync/.ToHashSetAsync/.AsAsyncEnumerable extension methods with EntitySet
+[postgresql] Improved database structucture extraction
+[postgresql] Addressed certain cases of decimal results of aggregate operations being unable to fit to .NET decimal

Orm/Xtensive.Orm.Manual/DomainAndSession/DomainAndSessionSample.cs

@@ -46,7 +46,7 @@ public class DomainAndSessionSample : HasConfigurationAccessTest
     public const string OracleUrl1     = @"oracle://user:password@localhost/MyDatabase";
     public const string OracleUrl2     = @"oracle://user:password@dbServer:5511/MyDatabase";
     public const string PostrgeSqlUrl1 = @"postgresql://user:[email protected]:8032/MyDatabase?Encoding=Unicode";
-    public const string PostrgeSqlUrl2 = @"postgresql://user:password@dbServer/MyDatabase?Pooling=on&MinPoolSize=1&MaxPoolSize=5";
+    public const string PostrgeSqlUrl2 = @"postgresql://user:password@dbServer/MyDatabase?Pooling=True&MinPoolSize=1&MaxPoolSize=5";
     public const string InMemoryUrl    = @"memory://localhost/MyDatabase";
 
     #endregion

Orm/Xtensive.Orm.MySql/Xtensive.Orm.MySql.csproj

@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <IsPackable>true</IsPackable>
     <DocumentationFile>$(OutputPath)$(TargetFramework)\$(AssemblyName).xml</DocumentationFile>
@@ -39,8 +39,7 @@
     </EmbeddedResource>
   </ItemGroup>
   <ItemGroup>
-    <PackageReference Include="Google.Protobuf" Version="3.19.4" />
-    <PackageReference Include="MySql.Data" Version="8.0.30" />
+    <PackageReference Include="MySql.Data" Version="8.0.31" />
     <PackageReference Include="System.Xml.XPath.XmlDocument" Version="4.3.0" />
   </ItemGroup>
   <ItemGroup>

Orm/Xtensive.Orm.Oracle/Xtensive.Orm.Oracle.csproj

@@ -25,7 +25,7 @@
     </Content>
   </ItemGroup>
   <ItemGroup>
-    <PackageReference Include="Oracle.ManagedDataAccess.Core" Version="2.18.3" />
+    <PackageReference Include="Oracle.ManagedDataAccess.Core" Version="2.18.151" />
   </ItemGroup>
   <ItemGroup>
     <ProjectReference Include="..\Xtensive.Orm\Xtensive.Orm.csproj" />

Orm/Xtensive.Orm.PostgreSql/Orm.Providers.PostgreSql/SqlCompiler.cs

@@ -4,6 +4,7 @@
 // Created by: Denis Krjuchkov
 // Created:    2009.04.27
 
+using System;
 using System.Collections.Generic;
 using System.Linq;
 using Xtensive.Core;
@@ -18,6 +19,8 @@ namespace Xtensive.Orm.Providers.PostgreSql
 {
   internal class SqlCompiler : Providers.SqlCompiler
   {
+    private const int MaxDotnetDecimalPrecision = 28;
+
     protected override SqlProvider VisitFreeText(FreeTextProvider provider)
     {
       var rankColumnName = provider.Header.Columns[provider.Header.Columns.Count - 1].Name;
@@ -55,13 +58,83 @@ protected override SqlProvider VisitFreeText(FreeTextProvider provider)
     protected override SqlExpression ProcessAggregate(SqlProvider source, List<SqlExpression> sourceColumns, AggregateColumn aggregateColumn)
     {
       var result = base.ProcessAggregate(source, sourceColumns, aggregateColumn);
-      if (aggregateColumn.AggregateType == AggregateType.Sum || aggregateColumn.AggregateType == AggregateType.Avg) {
+      var aggregateType = aggregateColumn.AggregateType;
+      var originCalculateColumn = source.Origin.Header.Columns[aggregateColumn.SourceIndex];
+      if (AggregateRequiresDecimalAdjustments(aggregateColumn)) {
+        if (!IsCalculatedColumn(originCalculateColumn)) {
+          // this is aggregate by one column, result will be defined by the precision and scale of the column
+          return result;
+        }
+
+        // For expressions we had to try to guess result type parameters to avoid overflow exception
+        // on reading something like 12.000000000000000000000000000000 (30 zeros) which in practice can be reduced
+        // to 12.0 on reading but Npgsql does not allow us neither to turn on such conversion inside Npgsql (as it was in v3.x.x) nor
+        // to get raw data and make conversion by ourselves (because nothing similar to SqlDecimal has provided by the library).
+
+        // Official answer of the Npgsql team is to either cast to DECIMAL with proper parameters or read all parameters as
+        // strings and then convert :-)
+        // Reading strings is not an option so we try to tell fortunes in a teacup :-(
+        var resultType = (!TryAdjustPrecisionScale(aggregateColumn.Descriptor.DecimalParametersHint, aggregateType, out var newPrecision, out var newScale))
+          ? Driver.MapValueType(aggregateColumn.Type)
+          : Driver.MapValueType(aggregateColumn.Type, null, newPrecision, newScale);
+        return SqlDml.Cast(result, resultType);
+      }
+      else if (aggregateType != AggregateType.Count) {
         result = SqlDml.Cast(result, Driver.MapValueType(aggregateColumn.Type));
       }
-
       return result;
     }
 
+    private bool AggregateRequiresDecimalAdjustments(AggregateColumn aggregateColumn)
+    {
+      var aggregateType = aggregateColumn.AggregateType;
+      return (aggregateType is AggregateType.Sum or AggregateType.Avg
+        or AggregateType.Min or AggregateType.Min) && aggregateColumn.Type == WellKnownTypes.DecimalType;
+    }
+
+    private bool TryAdjustPrecisionScale(
+      in (int precision, int scale)? typeHint,
+      in AggregateType aggregateType,
+      out int precision, out int scale)
+    {
+      if (!typeHint.HasValue) {
+        precision = -1;
+        scale = -1;
+        return false;
+      }
+      var typeHintValue = typeHint.Value;
+
+      if (typeHintValue.precision == MaxDotnetDecimalPrecision) {
+        // No room for adjust, otherwise we'll lose floor part data
+        precision = typeHintValue.precision;
+        scale = typeHintValue.scale;
+        return true;
+      }
+
+      // choose max available precision for .net or let it be the one user declared
+      precision = (typeHintValue.precision < 28) ? 28 : typeHintValue.precision;
+
+      // It is benefitial to increase scale but for how much? It is open question,
+      // sometimes we need bigger floor part, and sometimes bigger fractional part.
+      // This algorithm is a trade-off.
+      scale = aggregateType switch {
+        AggregateType.Avg =>
+          (typeHintValue.precision < MaxDotnetDecimalPrecision)
+            ? typeHintValue.scale + Math.Max((precision - typeHintValue.precision) / 2, 1)
+            : typeHintValue.scale + 1,
+        AggregateType.Sum or
+          AggregateType.Min or
+          AggregateType.Max =>
+            (typeHintValue.precision < MaxDotnetDecimalPrecision - 1)
+              ? typeHintValue.scale + 2
+              : typeHintValue.scale + 1,
+        _ => typeHintValue.scale,
+      };
+      return true;
+    }
+
+    private bool IsCalculatedColumn(Column column) => column is CalculatedColumn;
+
     public SqlCompiler(HandlerAccessor handlers, CompilerConfiguration configuration)
       : base(handlers, configuration)
     {

Orm/Xtensive.Orm.PostgreSql/Sql.Drivers.PostgreSql/DriverFactory.cs

@@ -111,19 +111,15 @@ private static SqlDriver CreateDriverInstance(
 
       // We support 8.3, 8.4 and any 9.0+
 
-      if (version.Major == 8) {
-        return version.Minor == 3 ? new v8_3.Driver(coreServerInfo) : new v8_4.Driver(coreServerInfo);
-      }
-
-      if (version.Major == 9) {
-        return version.Minor == 0 ? new v9_0.Driver(coreServerInfo) : new v9_1.Driver(coreServerInfo);
-      }
-
-      if (version.Major < 12) {
-        return new v10_0.Driver(coreServerInfo);
-      }
-
-      return new v12_0.Driver(coreServerInfo);
+      return version.Major switch {
+        8 when version.Minor == 3 => new v8_3.Driver(coreServerInfo),
+        8 when version.Minor > 3  => new v8_4.Driver(coreServerInfo),
+        9 when version.Minor == 0 => new v9_0.Driver(coreServerInfo),
+        9 when version.Minor > 0 => new v9_1.Driver(coreServerInfo),
+        10 => new v10_0.Driver(coreServerInfo),
+        11 => new v10_0.Driver(coreServerInfo),
+        _ => new v12_0.Driver(coreServerInfo)
+      };
     }
 
     /// <inheritdoc/>

Orm/Xtensive.Orm.PostgreSql/Sql.Drivers.PostgreSql/Resources/Strings.Designer.cs

@@ -135,4 +135,7 @@
   <data name="ExSchemaXDoesNotExistOrBelongsToAnotherUser" xml:space="preserve">
     <value>Schema '{0}' either does not exist or belongs to another user.</value>
   </data>
+  <data name="ExCantFindSchemaXOwnerWithIdYInTheListOfRoles" xml:space="preserve">
+    <value>Can't find schema '{0}' owner with oid '{1}' in the list of roles.</value>
+  </data>
 </root>