Skip to content

Commit 25875c8

Browse files
Merge pull request #238 from willNium/checking-config-option
feat: reads config option to be compatible with serverless v1.45.0
2 parents 863e2fd + b496c85 commit 25875c8

File tree

2 files changed

+23
-1
lines changed

2 files changed

+23
-1
lines changed

lib/yamlParser.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@ module.exports = {
1111
return BbPromise.resolve();
1212
}
1313

14-
const serverlessYmlPath = path.join(servicePath, 'serverless.yml');
14+
const serviceFileName = this.serverless.config.serverless.service.serviceFilename || 'serverless.yml';
15+
const serverlessYmlPath = path.join(servicePath, serviceFileName);
1516
return this.serverless.yamlParser
1617
.parse(serverlessYmlPath)
1718
.then(serverlessFileParam => this.serverless.variables.populateObject(serverlessFileParam)

lib/yamlParser.test.js

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,27 @@ describe('#yamlParse', () => {
133133
expect(serverless.service.stepFunctions.activities).to.be.deep.equal([]);
134134
});
135135
});
136+
137+
it('should default to serverless.yml if serviceFileName (--config option) is not passed', () => {
138+
const servicePath = serverlessStepFunctions.serverless.config.servicePath;
139+
serverlessStepFunctions.serverless.config.serverless.service.serviceFilename = undefined;
140+
141+
serverlessStepFunctions.yamlParse()
142+
.then(() => {
143+
expect(yamlParserStub.calledWith(`${servicePath}/serverless.yml`)).to.be.equal(true);
144+
});
145+
});
146+
147+
it('should read serviceFileName if passed as --config option', () => {
148+
const servicePath = serverlessStepFunctions.serverless.config.servicePath;
149+
const fileName = 'other_config.yml';
150+
serverlessStepFunctions.serverless.config.serverless.service.serviceFilename = fileName;
151+
152+
serverlessStepFunctions.yamlParse()
153+
.then(() => {
154+
expect(yamlParserStub.calledWith(`${servicePath}/${fileName}`)).to.be.equal(true);
155+
});
156+
});
136157
});
137158

138159
describe('#getAllStateMachines()', () => {

0 commit comments

Comments
 (0)