BUG - Move config referencing out of plugin constructor

[mike-suggitt]

In looking to use this plugin over a number of environments (particularly localhost) I need to be able to change the config based on the environment. I typically like to do this via separate files and use the ${env} to switch between them. The problem is that variable interpolation isn't performed until AFTER plugin constructors are called which means if I try to do this with serverless-nextjs-plugin then it fails due to an uninterpolated string.

This is a bug/change request to follow serverless best practice and move config access into the relevant lifecycle hooks.

Same issue encountered and discussed here -> https://forum.serverless.com/t/serverless-plugin-resolving-variable-references/2233

Serverless PR updating docs for best practice -> https://github.com/serverless/serverless/pull/3911/files

Thanks, and great work btw!! :)

[mike-suggitt]

@danielcondemarin Could I possibly gets some thoughts/feedback at all please?

[mike-suggitt]

Any updates on this? It's literally killing off our usage of this plugin in our system :(

[danielcondemarin]

@mike-suggitt Sorry I've not had the time to look into this! Ive been quite busy getting the new version out. I would recommend you migrate over, otherwise I'll try having a look at this issue at some point this week

[mike-suggitt]

@danielcondemarin no worries, thanks for getting back to me! i could maybe look to create a PR for it if that would help? I'm hoping it should be simply enough to simply move a few lines of code out of the constructor

[danielcondemarin]

@mike-suggitt That's definitely best if you have the time. I'll happily review it 👍

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.