Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opt-in to TraceId enrichment for ASP.NET Core 5.0 logs - support in Serilog.Sinks.MSSqlServer #488

Closed
ccvik19 opened this issue Oct 25, 2023 · 2 comments · Fixed by #497
Closed
Labels

Comments

@ccvik19
Copy link

ccvik19 commented Oct 25, 2023

Please add TraceId support into the SQL Server sink.

This is related to the following issue:
serilog/serilog-aspnetcore#207

The TraceId was changed in .Net Core 5 and the TraceId is no longer included in the logs. Issue #207 was fixed, but each sink must implement the change. It looks like several sinks have been updated already, but Serilog.Sinks.MSSqlServer still doesn't have support. This is important to us, since we user the TraceId extensively.

List the names and versions of all Serilog packages used in the project:

  • Serilog:
  • Serilog.Sinks.MSSqlServer
  • Serilog.Enrichers.AspnetcoreHttpcontext
  • Serilog.Exceptions

Target framework and operating system:
[ ] .NET 6

Thanks you!

@ckadluba
Copy link
Member

Hi @ccvik19!

Thanks for pointing us at this recent development in serilog core. I will definitly have a look at this soon.

Cheers,
Christian ✌️

@ckadluba
Copy link
Member

There is now a preview version 6.5.0-dev-00060 of the MSSQL sink up on nuget.org (https://www.nuget.org/packages/Serilog.Sinks.MSSqlServer/6.5.0-dev-00060) containing support for TraceId and SpanId.

We would appreciate everyone who tries it out and gives us some feedback.

@ckadluba ckadluba mentioned this issue Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants