fix: respect min pool configuration #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -442,6 +442,15 @@ export class Pool<RawResource> { | |||
| this._pendingAcquires.push(deferred); | |||
| this._dispense(); | |||
|
|
|||
| let i, diff; | |||
There was a problem hiding this comment.
Looks like copy paste from _ensureMinimum, just call that method here?
There was a problem hiding this comment.
There is a subtle difference, _ensureMinimum calls createResource without returning a promise. Using ensure minimum would hence cause the acquire method to return before the resource creation is done. This would have the potential of an unhandled exception if the exception occurs after the promise is returned.
Should ensure minimum be updated to return a promise?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix #22 by acquiring up to the min connections.
I suspect I need to add handlers to make sure it doesn't dispose of the min connections, but not sure. Also unsure if this is the right way to resolve the issue. Wanted to get the conversation started via the PR.