fix(vroom): add persistent storage configuration (#1822)

Author: TartanLeGrand

charts/sentry/templates/_helper.tpl

@@ -683,7 +683,7 @@ Set external Clickhouse password from existingSecret
 - name: SENTRY_KAFKA_BROKERS_OCCURRENCES
   value: {{ include "sentry.kafka.bootstrap_servers_string" . | quote }}
 - name: SENTRY_BUCKET_PROFILES
-  value: file://localhost//var/lib/sentry-profiles
+  value: "file:///var/vroom/sentry-profiles"
 - name: SENTRY_SNUBA_HOST
   value: http://{{ template "sentry.fullname" . }}-snuba:{{ template "snuba.port" . }}
 {{- end -}}

charts/sentry/templates/sentry/vroom/deployment-vroom.yaml

@@ -85,11 +85,14 @@ spec:
         env:
         - name: VROOM_PORT
           value: '{{ template "vroom.port" }}'
+{{- include "vroom.env" . | nindent 8 }}
 {{- if .Values.vroom.env }}
 {{ toYaml .Values.vroom.env | indent 8 }}
 {{- end }}
-{{- if .Values.vroom.volumeMounts }}
         volumeMounts:
+        - name: vroom-storage
+          mountPath: /var/vroom/sentry-profiles
+{{- if .Values.vroom.volumeMounts }}
 {{ toYaml .Values.vroom.volumeMounts | indent 10 }}
 {{- end }}
         livenessProbe:
@@ -127,14 +130,20 @@ spec:
       {{- if .Values.serviceAccount.enabled }}
       serviceAccountName: {{ .Values.serviceAccount.name }}-vroom
       {{- end }}
-{{- if or .Values.vroom.volumes .Values.global.volumes }}
       volumes:
+      {{- if .Values.vroom.persistence.enabled }}
+      - name: vroom-storage
+        persistentVolumeClaim:
+          claimName: sentry-vroom-pvc
+      {{- else }}
+      - name: vroom-storage
+        emptyDir: {}
+      {{- end }}
 {{- if .Values.vroom.volumes }}
 {{ toYaml .Values.vroom.volumes | indent 6 }}
 {{- end }}
 {{- if .Values.global.volumes }}
 {{ toYaml .Values.global.volumes | indent 6 }}
-{{- end }}
 {{- end }}
       {{- if .Values.vroom.priorityClassName }}
       priorityClassName: "{{ .Values.vroom.priorityClassName }}"

charts/sentry/templates/sentry/vroom/pvc-vroom.yaml

@@ -0,0 +1,28 @@
+{{- if has "feature-complete" .Values.profiles }}
+{{- if .Values.sentry.features.enableProfiling }}
+{{- if .Values.vroom.persistence.enabled }}
+apiVersion: v1
+kind: PersistentVolumeClaim
+metadata:
+  name: sentry-vroom-pvc
+  namespace: {{ .Release.Namespace }}
+  labels:
+    app: {{ template "sentry.fullname" . }}
+    chart: "{{ .Chart.Name }}-{{ .Chart.Version | replace "+" "_" }}"
+    release: "{{ .Release.Name }}"
+    heritage: "{{ .Release.Service }}"
+    component: vroom
+spec:
+  accessModes:
+{{- range .Values.vroom.persistence.accessModes }}
+    - {{ . | quote }}
+{{- end }}
+  resources:
+    requests:
+      storage: {{ .Values.vroom.persistence.size | quote }}
+  {{- if .Values.vroom.persistence.storageClassName }}
+  storageClassName: {{ .Values.vroom.persistence.storageClassName | quote }}
+  {{- end }}
+{{- end }}
+{{- end }}
+{{- end }}

charts/sentry/values.yaml

@@ -97,6 +97,12 @@ vroom:
     annotations: {}
   # tolerations: []
   # podLabels: {}
+  persistence:
+    enabled: true  # Set true for using PersistentVolumeClaim, false for emptyDir
+    accessModes:
+      - ReadWriteOnce
+    # storageClassName: standard
+    size: "10Gi"
 
   autoscaling:
     enabled: false