Skip to content

Commit edecf92

Browse files
pvdlggr2m
pvdlg
authored and
gr2m
committed
fix: use proper query for searching title
1 parent fbf1246 commit edecf92

File tree

5 files changed

+52
-52
lines changed

5 files changed

+52
-52
lines changed

‎lib/find-sr-issues.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ const ISSUE_ID = require('./definitions/sr-issue-id');
22

33
module.exports = async (github, title, owner, repo) => {
44
const {data: {items: issues}} = await github.search.issues({
5-
q: `title:${title}+repo:${owner}/${repo}+type:issue+state:open`,
5+
q: `in:title+repo:${owner}/${repo}+type:issue+state:open+${title}`,
66
});
77

88
return issues.filter(issue => issue.body && issue.body.includes(ISSUE_ID));

‎test/fail.test.js‎

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,9 @@ test.serial('Open a new issue with the list of errors', async t => {
4747
];
4848
const github = authenticate()
4949
.get(
50-
`/search/issues?q=${escape(`title:${failTitle}`)}+${escape(`repo:${owner}/${repo}`)}+${escape(
51-
'type:issue'
52-
)}+${escape('state:open')}`
50+
`/search/issues?q=${escape('in:title')}+${escape(`repo:${owner}/${repo}`)}+${escape('type:issue')}+${escape(
51+
'state:open'
52+
)}+${escape(failTitle)}`
5353
)
5454
.reply(200, {items: []})
5555
.post(`/repos/${owner}/${repo}/issues`, {
@@ -80,9 +80,9 @@ test.serial('Open a new issue with the list of errors and custom title and comme
8080
];
8181
const github = authenticate()
8282
.get(
83-
`/search/issues?q=${escape(`title:${failTitle}`)}+${escape(`repo:${owner}/${repo}`)}+${escape(
84-
'type:issue'
85-
)}+${escape('state:open')}`
83+
`/search/issues?q=${escape('in:title')}+${escape(`repo:${owner}/${repo}`)}+${escape('type:issue')}+${escape(
84+
'state:open'
85+
)}+${escape(failTitle)}`
8686
)
8787
.reply(200, {items: []})
8888
.post(`/repos/${owner}/${repo}/issues`, {
@@ -112,9 +112,9 @@ test.serial('Open a new issue with assignees and the list of errors', async t =>
112112
];
113113
const github = authenticate()
114114
.get(
115-
`/search/issues?q=${escape(`title:${failTitle}`)}+${escape(`repo:${owner}/${repo}`)}+${escape(
116-
'type:issue'
117-
)}+${escape('state:open')}`
115+
`/search/issues?q=${escape('in:title')}+${escape(`repo:${owner}/${repo}`)}+${escape('type:issue')}+${escape(
116+
'state:open'
117+
)}+${escape(failTitle)}`
118118
)
119119
.reply(200, {items: []})
120120
.post(`/repos/${owner}/${repo}/issues`, {
@@ -145,9 +145,9 @@ test.serial('Open a new issue without labels and the list of errors', async t =>
145145
];
146146
const github = authenticate()
147147
.get(
148-
`/search/issues?q=${escape(`title:${failTitle}`)}+${escape(`repo:${owner}/${repo}`)}+${escape(
149-
'type:issue'
150-
)}+${escape('state:open')}`
148+
`/search/issues?q=${escape('in:title')}+${escape(`repo:${owner}/${repo}`)}+${escape('type:issue')}+${escape(
149+
'state:open'
150+
)}+${escape(failTitle)}`
151151
)
152152
.reply(200, {items: []})
153153
.post(`/repos/${owner}/${repo}/issues`, {
@@ -182,9 +182,9 @@ test.serial('Update the first existing issue with the list of errors', async t =
182182
];
183183
const github = authenticate()
184184
.get(
185-
`/search/issues?q=${escape(`title:${failTitle}`)}+${escape(`repo:${owner}/${repo}`)}+${escape(
186-
'type:issue'
187-
)}+${escape('state:open')}`
185+
`/search/issues?q=${escape('in:title')}+${escape(`repo:${owner}/${repo}`)}+${escape('type:issue')}+${escape(
186+
'state:open'
187+
)}+${escape(failTitle)}`
188188
)
189189
.reply(200, {items: issues})
190190
.post(`/repos/${owner}/${repo}/issues/2/comments`, {

‎test/find-sr-issue.test.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,9 @@ test.serial('Filter out issues without ID', async t => {
4545
];
4646
const github = authenticate({githubToken})
4747
.get(
48-
`/search/issues?q=${escape(`title:${title}`)}+${escape(`repo:${owner}/${repo}`)}+${escape('type:issue')}+${escape(
48+
`/search/issues?q=${escape('in:title')}+${escape(`repo:${owner}/${repo}`)}+${escape('type:issue')}+${escape(
4949
'state:open'
50-
)}`
50+
)}+${escape(title)}`
5151
)
5252
.reply(200, {items: issues});
5353

@@ -69,9 +69,9 @@ test.serial('Return empty array if not issues found', async t => {
6969
const issues = [];
7070
const github = authenticate({githubToken})
7171
.get(
72-
`/search/issues?q=${escape(`title:${title}`)}+${escape(`repo:${owner}/${repo}`)}+${escape('type:issue')}+${escape(
72+
`/search/issues?q=${escape('in:title')}+${escape(`repo:${owner}/${repo}`)}+${escape('type:issue')}+${escape(
7373
'state:open'
74-
)}`
74+
)}+${escape(title)}`
7575
)
7676
.reply(200, {items: issues});
7777

@@ -90,9 +90,9 @@ test.serial('Return empty array if not issues has matching ID', async t => {
9090
const issues = [{number: 1, body: 'Issue 1 body', title}, {number: 2, body: 'Issue 2 body', title}];
9191
const github = authenticate({githubToken})
9292
.get(
93-
`/search/issues?q=${escape(`title:${title}`)}+${escape(`repo:${owner}/${repo}`)}+${escape('type:issue')}+${escape(
93+
`/search/issues?q=${escape('in:title')}+${escape(`repo:${owner}/${repo}`)}+${escape('type:issue')}+${escape(
9494
'state:open'
95-
)}`
95+
)}+${escape(title)}`
9696
)
9797
.reply(200, {items: issues});
9898

‎test/integration.test.js‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -200,9 +200,9 @@ test.serial('Comment on PR included in the releases', async t => {
200200
.post(`/repos/${owner}/${repo}/issues/1/comments`, {body: /This PR is included/})
201201
.reply(200, {html_url: 'https://github.com/successcomment-1'})
202202
.get(
203-
`/search/issues?q=${escape(`title:${failTitle}`)}+${escape(`repo:${owner}/${repo}`)}+${escape(
204-
'type:issue'
205-
)}+${escape('state:open')}`
203+
`/search/issues?q=${escape('in:title')}+${escape(`repo:${owner}/${repo}`)}+${escape('type:issue')}+${escape(
204+
'state:open'
205+
)}+${escape(failTitle)}`
206206
)
207207
.reply(200, {items: []});
208208

@@ -228,9 +228,9 @@ test.serial('Open a new issue with the list of errors', async t => {
228228
.get(`/repos/${owner}/${repo}`)
229229
.reply(200, {permissions: {push: true}})
230230
.get(
231-
`/search/issues?q=${escape(`title:${failTitle}`)}+${escape(`repo:${owner}/${repo}`)}+${escape(
232-
'type:issue'
233-
)}+${escape('state:open')}`
231+
`/search/issues?q=${escape('in:title')}+${escape(`repo:${owner}/${repo}`)}+${escape('type:issue')}+${escape(
232+
'state:open'
233+
)}+${escape(failTitle)}`
234234
)
235235
.reply(200, {items: []})
236236
.post(`/repos/${owner}/${repo}/issues`, {
@@ -289,9 +289,9 @@ test.serial('Verify, release and notify success', async t => {
289289
.post(`/repos/${owner}/${repo}/issues/1/comments`, {body: /This PR is included/})
290290
.reply(200, {html_url: 'https://github.com/successcomment-1'})
291291
.get(
292-
`/search/issues?q=${escape(`title:${failTitle}`)}+${escape(`repo:${owner}/${repo}`)}+${escape(
293-
'type:issue'
294-
)}+${escape('state:open')}`
292+
`/search/issues?q=${escape('in:title')}+${escape(`repo:${owner}/${repo}`)}+${escape('type:issue')}+${escape(
293+
'state:open'
294+
)}+${escape(failTitle)}`
295295
)
296296
.reply(200, {items: []});
297297
const githubUpload1 = upload({
@@ -338,9 +338,9 @@ test.serial('Verify and notify failure', async t => {
338338
.get(`/repos/${owner}/${repo}`)
339339
.reply(200, {permissions: {push: true}})
340340
.get(
341-
`/search/issues?q=${escape(`title:${failTitle}`)}+${escape(`repo:${owner}/${repo}`)}+${escape(
342-
'type:issue'
343-
)}+${escape('state:open')}`
341+
`/search/issues?q=${escape('in:title')}+${escape(`repo:${owner}/${repo}`)}+${escape('type:issue')}+${escape(
342+
'state:open'
343+
)}+${escape(failTitle)}`
344344
)
345345
.reply(200, {items: []})
346346
.post(`/repos/${owner}/${repo}/issues`, {

‎test/success.test.js‎

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,9 @@ test.serial('Add comment to PRs associated with release commits and issues close
6464
.post(`/repos/${owner}/${repo}/issues/4/comments`, {body: /This issue has been resolved/})
6565
.reply(200, {html_url: 'https://github.com/successcomment-4'})
6666
.get(
67-
`/search/issues?q=${escape(`title:${failTitle}`)}+${escape(`repo:${owner}/${repo}`)}+${escape(
68-
'type:issue'
69-
)}+${escape('state:open')}`
67+
`/search/issues?q=${escape('in:title')}+${escape(`repo:${owner}/${repo}`)}+${escape('type:issue')}+${escape(
68+
'state:open'
69+
)}+${escape(failTitle)}`
7070
)
7171
.reply(200, {items: []});
7272

@@ -126,9 +126,9 @@ test.serial('Make multiple search queries if necessary', async t => {
126126
.post(`/repos/${owner}/${repo}/issues/6/comments`, {body: /This PR is included/})
127127
.reply(200, {html_url: 'https://github.com/successcomment-6'})
128128
.get(
129-
`/search/issues?q=${escape(`title:${failTitle}`)}+${escape(`repo:${owner}/${repo}`)}+${escape(
130-
'type:issue'
131-
)}+${escape('state:open')}`
129+
`/search/issues?q=${escape('in:title')}+${escape(`repo:${owner}/${repo}`)}+${escape('type:issue')}+${escape(
130+
'state:open'
131+
)}+${escape(failTitle)}`
132132
)
133133
.reply(200, {items: []});
134134

@@ -161,9 +161,9 @@ test.serial('Do not add comment if no PR is associated with release commits', as
161161
)
162162
.reply(200, {items: []})
163163
.get(
164-
`/search/issues?q=${escape(`title:${failTitle}`)}+${escape(`repo:${owner}/${repo}`)}+${escape(
165-
'type:issue'
166-
)}+${escape('state:open')}`
164+
`/search/issues?q=${escape('in:title')}+${escape(`repo:${owner}/${repo}`)}+${escape('type:issue')}+${escape(
165+
'state:open'
166+
)}+${escape(failTitle)}`
167167
)
168168
.reply(200, {items: []});
169169

@@ -199,9 +199,9 @@ test.serial('Add custom comment', async t => {
199199
})
200200
.reply(200, {html_url: 'https://github.com/successcomment-1'})
201201
.get(
202-
`/search/issues?q=${escape(`title:${failTitle}`)}+${escape(`repo:${owner}/${repo}`)}+${escape(
203-
'type:issue'
204-
)}+${escape('state:open')}`
202+
`/search/issues?q=${escape('in:title')}+${escape(`repo:${owner}/${repo}`)}+${escape('type:issue')}+${escape(
203+
'state:open'
204+
)}+${escape(failTitle)}`
205205
)
206206
.reply(200, {items: []});
207207

@@ -238,9 +238,9 @@ test.serial('Ignore errors when adding comments and closing issues', async t =>
238238
.post(`/repos/${owner}/${repo}/issues/2/comments`, {body: /This PR is included/})
239239
.reply(200, {html_url: 'https://github.com/successcomment-2'})
240240
.get(
241-
`/search/issues?q=${escape(`title:${failTitle}`)}+${escape(`repo:${owner}/${repo}`)}+${escape(
242-
'type:issue'
243-
)}+${escape('state:open')}`
241+
`/search/issues?q=${escape('in:title')}+${escape(`repo:${owner}/${repo}`)}+${escape('type:issue')}+${escape(
242+
'state:open'
243+
)}+${escape(failTitle)}`
244244
)
245245
.reply(200, {items: issues})
246246
.patch(`/repos/${owner}/${repo}/issues/2`, {state: 'closed'})
@@ -284,9 +284,9 @@ test.serial('Close open issues when a release is successful', async t => {
284284
)
285285
.reply(200, {items: []})
286286
.get(
287-
`/search/issues?q=${escape(`title:${failTitle}`)}+${escape(`repo:${owner}/${repo}`)}+${escape(
288-
'type:issue'
289-
)}+${escape('state:open')}`
287+
`/search/issues?q=${escape('in:title')}+${escape(`repo:${owner}/${repo}`)}+${escape('type:issue')}+${escape(
288+
'state:open'
289+
)}+${escape(failTitle)}`
290290
)
291291
.reply(200, {items: issues})
292292
.patch(`/repos/${owner}/${repo}/issues/2`, {state: 'closed'})

0 commit comments

Comments
 (0)