From 7c3169c464ebea23c8085e4d9d9dd74626001776 Mon Sep 17 00:00:00 2001 From: Ken Brownfield Date: Wed, 4 Sep 2019 15:28:58 -0700 Subject: [PATCH 1/4] Expose the calculated lag to Readers configured with a GroupID --- reader.go | 4 ---- 1 file changed, 4 deletions(-) diff --git a/reader.go b/reader.go index 825f6922e..6d875f4a1 100644 --- a/reader.go +++ b/reader.go @@ -892,10 +892,6 @@ func (r *Reader) Offset() int64 { // Lag returns the lag of the last message returned by ReadMessage, or -1 // if r is backed by a consumer group. func (r *Reader) Lag() int64 { - if r.useConsumerGroup() { - return -1 - } - r.mutex.Lock() lag := r.lag r.mutex.Unlock() From 486674bc4ea7919c80c658d17c02ac088f6cbcbc Mon Sep 17 00:00:00 2001 From: Ken Brownfield Date: Wed, 4 Sep 2019 15:41:11 -0700 Subject: [PATCH 2/4] Update comment appropriately --- reader.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/reader.go b/reader.go index 6d875f4a1..af3ba9105 100644 --- a/reader.go +++ b/reader.go @@ -889,8 +889,7 @@ func (r *Reader) Offset() int64 { return offset } -// Lag returns the lag of the last message returned by ReadMessage, or -1 -// if r is backed by a consumer group. +// Lag returns the lag of the last message returned by ReadMessage or FetchMessage. func (r *Reader) Lag() int64 { r.mutex.Lock() lag := r.lag From 0e4740b13717cebbbb7af74ed86e92eee03eb376 Mon Sep 17 00:00:00 2001 From: Ken Brownfield Date: Wed, 16 Oct 2019 12:58:25 -0700 Subject: [PATCH 3/4] Change package for this branch so it can be imported --- go.mod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/go.mod b/go.mod index a5557c338..3910daa5b 100644 --- a/go.mod +++ b/go.mod @@ -1,4 +1,4 @@ -module github.com/segmentio/kafka-go +module github.com/wekb/kafka-go go 1.11 From 6b5a23db4379a0f9bf3abcdb60fc3c9c152d4571 Mon Sep 17 00:00:00 2001 From: Ken Brownfield Date: Wed, 16 Oct 2019 13:25:53 -0700 Subject: [PATCH 4/4] Keep PR clean Revert "Change package for this branch so it can be imported" This reverts commit 0e4740b13717cebbbb7af74ed86e92eee03eb376. --- go.mod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 3910daa5b..a5557c338 100644 --- a/go.mod +++ b/go.mod @@ -1,4 +1,4 @@ -module github.com/wekb/kafka-go +module github.com/segmentio/kafka-go go 1.11