Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should 'allExtensions' really be enabled by default? #1

Open
niklasbroberg opened this issue Nov 10, 2014 · 0 comments
Open

Should 'allExtensions' really be enabled by default? #1

niklasbroberg opened this issue Nov 10, 2014 · 0 comments

Comments

@niklasbroberg
Copy link
Contributor

The file should document what extensions it uses through LANGUAGE pragmas. Why do we auto-enable a (outdated) list of all extensions? I propose to instead enable a minimal amount of extensions, and otherwise use LANGUAGE pragmas.

Perhaps the most interesting question then is, should RegularPatterns and XmlSyntax be auto-enabled, or declared? I think the most consistent choice is to not auto-enable even them, instead forcing the file to declare their presence. That way GHC will correctly thrown an "Unknown extension" error if someone tries to bypass hsx2hs.

... though right now, hsx2hs doesn't remove those pragmas, so GHC will throw that error regardless. That's a separate bug though - see #2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant