Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore bin in node_modules? #4

Open
alexdresko opened this issue Jan 14, 2020 · 4 comments
Open

Ignore bin in node_modules? #4

alexdresko opened this issue Jan 14, 2020 · 4 comments

Comments

@alexdresko
Copy link

Does this tool know to avoid the bin directories that are sometimes within node_modules?

@sebnilsson
Copy link
Owner

Does this tool know to avoid the bin directories that are sometimes within node_modules?

It does not. It's not a scenario I've thought about.

I would have to come up with a concept to make this work, but I'm worried it'll be a complex concept, which will be hard to understand.

@alexdresko
Copy link
Author

I typically do this in powershell:

"bin", "obj", ".vs" | Get-ChildItem -Recurse -Directory | Where-Object { $_ -notlike "*node_modules*" } | Remove-Item -Recurse -Force -Verbose

@sebnilsson
Copy link
Owner

Technically, it's not hard to solve, but to expose the functionality in an understandable way in this tool is another matter.

@alexdresko
Copy link
Author

It seems universally true that you wouldn't want to delete the bin folders inside node_modules, unless you were specifically deleting node_modules. Why not just hard code it so you never delete anything under a node_modules folder unless you're deleting the node_modules folder?

I understand if that's easier said than done. I tried to look through the code here on GH, but it's a lot of code for something that basically does the same thing as "bin", "obj", ".vs" | Get-ChildItem -Recurse -Directory | Where-Object { $_ -notlike "*node_modules*" } | Remove-Item -Recurse -Force -Verbose :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants