Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize kernel parameters add #730

Open
eroussy opened this issue Feb 18, 2025 · 2 comments
Open

Harmonize kernel parameters add #730

eroussy opened this issue Feb 18, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@eroussy
Copy link
Member

eroussy commented Feb 18, 2025

Abstract
Two different methods are used to add new kernel parameters between Debian and Yocto. We should be able to use the same.

Current status
On Yocto:

  • Ansible variable extra_kernel_parameters
  • Applied by the role roles/yocto/kernel_params

On Debian:

  • Ansible variable grub_append
  • Applied during the role roles/debian

Detailed Description
The mechanism is the same in the two cases :

  • mount /boot partition if not done
  • modify grub.cfg file
  • regenerate grub

A common playbook/role must be used

Benefits to SEAPATH

  • Simpler for new user
  • Clearer

Work to be done
Create a common role that works both on Debian and Yocto

  • Make the mount and umount of /boot optional
  • keep the kernel_parameters_restart variable to eventually reboot the machine once it is done
  • Remove old mechanism in Debian and yocto roles
  • update ABB inventory example
@eroussy eroussy added the enhancement New feature or request label Feb 18, 2025
@eroussy
Copy link
Member Author

eroussy commented Feb 18, 2025

@insatomcat @dupremathieu What do you think of this proposition ?

@insatomcat
Copy link
Member

insatomcat commented Feb 18, 2025

On debian, we change the /etc/default/grub file and call update-grub, which is a command that will generate the grub.cfg.
On Yocto, if I understand the role correctly you mount the /boot, change the grub.cfg directly and unmount the /boot.
It does not seem like yocto and debian share any logic, so I don't really see the point of a common role.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants