Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

screen function spec is not correct #7

Open
carocad opened this issue Jan 8, 2018 · 0 comments
Open

screen function spec is not correct #7

carocad opened this issue Jan 8, 2018 · 0 comments

Comments

@carocad
Copy link

carocad commented Jan 8, 2018

I recently decided to instrument my entire project to check against possible errors. To my surprise, the project started to crash due to screen fdef instrumentation.

After some checking I found out the problem: fdef screen uses s/tuple to define the arguments; tuple however requires a vector but the arguments to a function are passed as a list which are not the same.

See this Clojure ticket for more information: https://dev.clojure.org/jira/browse/CLJ-2071

I think the correct way should be:

(s/fdef screen
        :args (s/cat :component :react/component 
                            :options :react-navigation/navigationOptions)
        :ret #(ric/react-class? %))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant