Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation failing #7

Open
maxspahn opened this issue Sep 15, 2024 · 0 comments
Open

Installation failing #7

maxspahn opened this issue Sep 15, 2024 · 0 comments

Comments

@maxspahn
Copy link

maxspahn commented Sep 15, 2024

Hi @hojae-io and @se-hwan again,

I know I am a bit annoying but when installing cusadi and trying it out, I encountered two minor bugs:

  1. The script to generate the code expects an existing build-folder:

    status = os.system("cd build && cmake .. && make -j")

    You can fix this by either asking the user to create one in the README.md, or adding it in the script.

  2. The generated CMakeLists.txt contains the line:

    find_package(CUDAToolkit REQUIRED)

    This feature has been deprecated in more recent versions of cmake, see https://cmake.org/cmake/help/v3.20/module/FindCUDA.html. For me it was fine to simply remove that line.

On that remark, one question: Why do you upload the CMakeLists.txt when it is generated either way?

As before, let me know if you want my help on this one

Best,
@maxspahn

itsikelis added a commit to itsikelis/cusadi that referenced this issue Oct 8, 2024
- Add mkdir -p build option in run_codegen.py
- Remove deprecated find_package(CUDAToolkit REQUIRED) from generateCUDACode.py
- Add build/ and generated CMakeLists.txt file in gitignore
itsikelis added a commit to itsikelis/cusadi that referenced this issue Oct 8, 2024
- Add mkdir -p build option in run_codegen.py
- Remove deprecated find_package(CUDAToolkit REQUIRED) from generateCUDACode.py
- Add build/ and generated CMakeLists.txt file in gitignore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant