Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jQuery Dependency #29

Open
regnerus opened this issue Jun 13, 2015 · 1 comment
Open

Remove jQuery Dependency #29

regnerus opened this issue Jun 13, 2015 · 1 comment

Comments

@regnerus
Copy link

Is it a possibility to remove jQuery in shell.js and pathhandler.js? It seems a bit overkill to me to add such a heavy dependency.

@sdether
Copy link
Owner

sdether commented Jun 13, 2015

Pathhandler.js doesn't actually use it, so removing it there is no problem. Shell.js on the other hand is the optional UI layer and requires some cross-browser compatible DOM manipulation. Since it already makes DOM assumptions that are likely at odds with a lot of frameworks, I'd rather re-invent that wheel and let people opt-in to use shell.js with the jQuery or adapt their own shell based no their favorite DOM abstraction.

I'm not opposed to a pull request that rips it out as long as the DOM code does cover the usual suspects of browsers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants