WIP: Replace allow with expect

Author: Lorak-mmk

examples/basic.rs

@@ -61,7 +61,7 @@ async fn main() -> Result<()> {
     }
 
     // Or as custom structs that derive DeserializeRow
-    #[allow(unused)]
+    #[expect(unused)]
     #[derive(Debug, DeserializeRow)]
     struct RowData {
         a: i32,

scylla-cql/src/deserialize/result.rs

@@ -175,7 +175,7 @@ impl RawRowLendingIterator {
     /// The column iterator must be consumed before the rows iterator can
     /// continue.
     #[inline]
-    #[allow(clippy::should_implement_trait)] // https://github.com/rust-lang/rust-clippy/issues/5004
+    #[expect(clippy::should_implement_trait)] // https://github.com/rust-lang/rust-clippy/issues/5004
     pub fn next(&mut self) -> Option<Result<ColumnIterator, DeserializationError>> {
         self.remaining = self.remaining.checked_sub(1)?;
 
@@ -258,7 +258,7 @@ mod tests {
 
     // Disable the lint, if there is more than one lifetime included.
     // Can be removed once https://github.com/rust-lang/rust-clippy/issues/12495 is fixed.
-    #[allow(clippy::needless_lifetimes)]
+    #[expect(clippy::needless_lifetimes)]
     impl<'frame, 'metadata> LendingIterator for RawRowIterator<'frame, 'metadata> {
         type Item<'borrow>
             = ColumnIterator<'borrow, 'borrow>

scylla-cql/src/deserialize/row_tests.rs

@@ -932,9 +932,9 @@ fn metadata_does_not_bound_deserialized_rows() {
         #[derive(DeserializeRow)]
         #[scylla(crate=crate)]
         struct MyRow<'frame> {
-            #[allow(dead_code)]
+            #[expect(dead_code)]
             bytes: &'frame [u8],
-            #[allow(dead_code)]
+            #[expect(dead_code)]
             text: &'frame str,
         }
         let decoded_custom_struct_res = deserialize::<MyRow>(row_typ, &bytes);

scylla-cql/src/deserialize/value_tests.rs

@@ -42,7 +42,7 @@ fn test_custom_cassandra_type_parser() {
             dimensions: 5,
         },
     ),
-    (  "636f6c756d6e:org.apache.cassandra.db.marshal.ListType(org.apache.cassandra.db.marshal.Int32Type)", 
+    (  "636f6c756d6e:org.apache.cassandra.db.marshal.ListType(org.apache.cassandra.db.marshal.Int32Type)",
         ColumnType::Collection {
             frozen: false,
             typ: CollectionType::List(Box::new(ColumnType::Native(NativeType::Int))),
@@ -2781,9 +2781,9 @@ fn metadata_does_not_bound_deserialized_values() {
         #[derive(DeserializeValue)]
         #[scylla(crate=crate)]
         struct Udt<'frame> {
-            #[allow(dead_code)]
+            #[expect(dead_code)]
             bytes: &'frame [u8],
-            #[allow(dead_code)]
+            #[expect(dead_code)]
             text: &'frame str,
         }
         let decoded_udt_res = deserialize::<Udt>(&udt_typ, &bytes);

scylla-cql/src/frame/request/batch.rs

@@ -228,7 +228,7 @@ impl BatchStatement<'_> {
 
 // Disable the lint, if there is more than one lifetime included.
 // Can be removed once https://github.com/rust-lang/rust-clippy/issues/12495 is fixed.
-#[allow(clippy::needless_lifetimes)]
+#[expect(clippy::needless_lifetimes)]
 impl<'s, 'b> From<&'s BatchStatement<'b>> for BatchStatement<'s> {
     fn from(value: &'s BatchStatement) -> Self {
         match value {

scylla-cql/src/frame/request/mod.rs

@@ -162,7 +162,7 @@ impl Request<'_> {
             Request::Query(q) => Some(q.parameters.consistency),
             Request::Execute(e) => Some(e.parameters.consistency),
             Request::Batch(b) => Some(b.consistency),
-            #[allow(unreachable_patterns)] // until other opcodes are supported
+            #[expect(unreachable_patterns)] // until other opcodes are supported
             _ => None,
         }
     }
@@ -173,7 +173,7 @@ impl Request<'_> {
             Request::Query(q) => Some(q.parameters.serial_consistency),
             Request::Execute(e) => Some(e.parameters.serial_consistency),
             Request::Batch(b) => Some(b.serial_consistency),
-            #[allow(unreachable_patterns)] // until other opcodes are supported
+            #[expect(unreachable_patterns)] // until other opcodes are supported
             _ => None,
         }
     }

scylla-cql/src/frame/response/result.rs

@@ -260,7 +260,7 @@ impl ColumnType<'_> {
     // Scylla's set of types supported for empty values as it's smaller;
     // with Cassandra, some rejects will just have to be rejected on the db side.
     pub(crate) fn supports_special_empty_value(&self) -> bool {
-        #[allow(clippy::match_like_matches_macro)]
+        #[expect(clippy::match_like_matches_macro)]
         match self {
             ColumnType::Native(NativeType::Counter)
             | ColumnType::Native(NativeType::Duration)

scylla-cql/src/serialize/row_tests.rs

@@ -669,7 +669,7 @@ struct TestRowWithSkippedFields {
     a: String,
     b: i32,
     #[scylla(skip)]
-    #[allow(dead_code)]
+    #[expect(dead_code)]
     skipped: Vec<String>,
     c: Vec<i64>,
 }

scylla-cql/src/serialize/value_tests.rs

@@ -522,7 +522,7 @@ fn test_cql_value_udt_errors() {
 // Do not remove. It's not used in tests but we keep it here to check that
 // we properly ignore warnings about unused variables, unnecessary `mut`s
 // etc. that usually pop up when generating code for empty structs.
-#[allow(unused)]
+#[expect(unused)]
 #[derive(SerializeValue)]
 #[scylla(crate = crate)]
 struct TestUdtWithNoFields {}
@@ -1162,7 +1162,7 @@ fn test_udt_serialization_with_field_rename_and_enforce_order() {
     assert_eq!(reference, udt);
 }
 
-#[allow(unused)]
+#[expect(unused)]
 #[derive(SerializeValue, Debug)]
 #[scylla(crate = crate, flavor = "enforce_order", skip_name_checks)]
 struct TestUdtWithSkippedNameChecks {
@@ -1329,7 +1329,7 @@ struct TestUdtWithSkippedFields {
     a: String,
     b: i32,
     #[scylla(skip)]
-    #[allow(dead_code)]
+    #[expect(dead_code)]
     skipped: Vec<String>,
     c: Vec<i64>,
 }

scylla-macros/src/deserialize/row.rs

@@ -322,7 +322,7 @@ impl DeserializeAssumeOrderGenerator<'_> {
 
         parse_quote! {
             fn deserialize(
-                #[allow(unused_mut)]
+                #[expect(unused_mut)]
                 mut row: #macro_internal::ColumnIterator<#frame_lifetime, #metadata_lifetime>,
             ) -> ::std::result::Result<Self, #macro_internal::DeserializationError> {
                 ::std::result::Result::Ok(Self {
@@ -576,7 +576,7 @@ impl DeserializeUnorderedGenerator<'_> {
 
         parse_quote! {
             fn deserialize(
-                #[allow(unused_mut)]
+                #[expect(unused_mut)]
                 mut row: #macro_internal::ColumnIterator<#frame_lifetime, #metadata_lifetime>,
             ) -> ::std::result::Result<Self, #macro_internal::DeserializationError> {
 

scylla-macros/src/deserialize/value.rs

@@ -536,7 +536,7 @@ impl DeserializeAssumeOrderGenerator<'_> {
         let field_idents = fields.iter().map(|f| f.ident.as_ref().unwrap());
         let field_finalizers = fields.iter().map(|f| self.generate_finalize_field(f));
 
-        #[allow(unused_mut)]
+        #[expect(unused_mut)]
         let mut iterator_type: syn::Type =
             parse_quote!(#macro_internal::UdtIterator<#frame_lifetime, #metadata_lifetime>);
 

scylla-macros/src/serialize/row.rs

@@ -396,7 +396,7 @@ impl Generator for ColumnSortingGenerator<'_> {
                 #partial_struct
                 #partial_serialize
 
-                #[allow(non_local_definitions)]
+                #[expect(non_local_definitions)]
                 #serialize_by_name
 
                 #crate_path::ser::row::ByName::<Self>::serialize(#crate_path::ser::row::ByName(self), ctx, writer)
@@ -447,7 +447,7 @@ impl Generator for ColumnOrderedGenerator<'_> {
                 ctx: &#crate_path::RowSerializationContext,
                 writer: &mut #crate_path::RowWriter<'_scylla_ser_row_writer_buffer>,
             ) -> ::std::result::Result<(), #crate_path::SerializationError> {
-                #[allow(non_local_definitions)]
+                #[expect(non_local_definitions)]
                 impl #impl_generics #crate_path::SerializeRowInOrder for #struct_name #ty_generics #where_clause {
                     fn serialize_in_order(
                         &self,

scylla-proxy/src/actions.rs

@@ -121,7 +121,7 @@ impl Condition {
     }
 
     /// A convenience function for creating [Condition::Not] variant.
-    #[allow(clippy::should_implement_trait)]
+    #[expect(clippy::should_implement_trait)]
     pub fn not(c: Self) -> Self {
         Condition::Not(Box::new(c))
     }

scylla-proxy/src/proxy.rs

@@ -1228,7 +1228,7 @@ impl ProxyWorker {
         .await;
     }
 
-    #[allow(clippy::too_many_arguments)]
+    #[expect(clippy::too_many_arguments)]
     async fn request_processor(
         self,
         mut requests_rx: mpsc::UnboundedReceiver<RequestFrame>,
@@ -1350,7 +1350,7 @@ impl ProxyWorker {
         .await;
     }
 
-    #[allow(clippy::too_many_arguments)]
+    #[expect(clippy::too_many_arguments)]
     async fn response_processor(
         self,
         mut responses_rx: mpsc::UnboundedReceiver<ResponseFrame>,

scylla/src/client/session.rs

@@ -854,7 +854,7 @@ impl Session {
         #[cfg(not(feature = "unstable-cloud"))]
         let cloud_known_nodes: Option<Vec<InternalKnownNode>> = None;
 
-        #[allow(clippy::unnecessary_literal_unwrap)]
+        #[expect(clippy::unnecessary_literal_unwrap)]
         let known_nodes = cloud_known_nodes
             .unwrap_or_else(|| known_nodes.into_iter().map(|node| node.into()).collect());
 
@@ -865,7 +865,7 @@ impl Session {
 
         let (tablet_sender, tablet_receiver) = tokio::sync::mpsc::channel(TABLET_CHANNEL_SIZE);
 
-        #[allow(unused_labels)] // Triggers when `cloud` feature is disabled.
+        #[expect(unused_labels)] // Triggers when `cloud` feature is disabled.
         let address_translator = 'translator: {
             #[cfg(feature = "unstable-cloud")]
             if let Some(translator) = config.cloud_config.clone() {
@@ -902,9 +902,9 @@ impl Session {
             if let Some(tls_context) = config.tls_context {
                 // To silence warnings when TlsContext is an empty enum (tls features are disabled).
                 // In such case, TlsProvider is uninhabited.
-                #[allow(unused_variables)]
+                #[expect(unused_variables)]
                 let provider = TlsProvider::new_with_global_context(tls_context);
-                #[allow(unreachable_code)]
+                #[expect(unreachable_code)]
                 break 'provider Some(provider);
             }
             None

scylla/src/client/session_builder.rs

@@ -28,7 +28,7 @@ use tracing::warn;
 mod sealed {
     // This is a sealed trait - its whole purpose is to be unnameable.
     // This means we need to disable the check.
-    #[allow(unnameable_types)]
+    #[expect(unnameable_types)]
     pub trait Sealed {}
 }
 pub trait SessionBuilderKind: sealed::Sealed + Clone {}

scylla/src/cloud/config.rs

@@ -168,9 +168,9 @@ pub enum CloudTlsProvider {
 #[derive(Debug)]
 pub(crate) struct AuthInfo {
     tls: TlsInfo,
-    #[allow(unused)]
+    #[expect(unused)]
     username: Option<String>,
-    #[allow(unused)]
+    #[expect(unused)]
     password: Option<String>,
 }
 
@@ -266,12 +266,12 @@ impl AuthInfo {
         &self.tls
     }
 
-    #[allow(unused)]
+    #[expect(unused)]
     pub(crate) fn get_username(&self) -> Option<&str> {
         self.username.as_deref()
     }
 
-    #[allow(unused)]
+    #[expect(unused)]
     pub(crate) fn get_password(&self) -> Option<&str> {
         self.password.as_deref()
     }
@@ -282,11 +282,11 @@ impl AuthInfo {
 pub(crate) struct Datacenter {
     ca_cert: TlsCert,
     server: String,
-    #[allow(unused)]
+    #[expect(unused)]
     tls_server_name: Option<String>,
     node_domain: String,
     insecure_skip_tls_verify: bool,
-    #[allow(unused)]
+    #[expect(unused)]
     proxy_url: Option<String>,
 }
 
@@ -295,7 +295,7 @@ impl Datacenter {
         &self.server
     }
 
-    #[allow(unused)]
+    #[expect(unused)]
     pub(crate) fn get_tls_server_name(&self) -> Option<&str> {
         self.tls_server_name.as_deref()
     }
@@ -308,7 +308,7 @@ impl Datacenter {
         self.insecure_skip_tls_verify
     }
 
-    #[allow(unused)]
+    #[expect(unused)]
     pub(crate) fn get_proxy_url(&self) -> Option<&str> {
         self.proxy_url.as_deref()
     }
@@ -326,7 +326,7 @@ impl TlsCert {
     #[cfg(feature = "openssl-010")]
     fn openssl_ca(&self) -> Option<&openssl::x509::X509> {
         // To silence the compiler warnings when enum consists of only one variant.
-        #[allow(irrefutable_let_patterns)]
+        #[expect(irrefutable_let_patterns)]
         if let TlsCert::OpenSsl010(ca) = self {
             Some(ca)
         } else {
@@ -337,7 +337,7 @@ impl TlsCert {
     #[cfg(feature = "rustls-023")]
     fn rustls_ca(&self) -> Option<&rustls::pki_types::CertificateDer<'static>> {
         // To silence the compiler warnings when enum consists of only one variant.
-        #[allow(irrefutable_let_patterns)]
+        #[expect(irrefutable_let_patterns)]
         if let TlsCert::Rustls023(ca) = self {
             Some(ca)
         } else {
@@ -371,7 +371,7 @@ mod deserialize {
     const NODE_DOMAIN_MAX_LENGTH: usize = 255 - 32 - 4 - 1;
 
     #[derive(Deserialize)]
-    #[allow(non_snake_case)]
+    #[expect(non_snake_case)]
     struct RawCloudConfig {
         // Kind is a string value representing the REST resource this object represents.
         // Servers may infer this from the endpoint the client submits requests to.
@@ -402,7 +402,7 @@ mod deserialize {
         parameters: Option<Parameters>,
     }
 
-    #[allow(non_snake_case)]
+    #[expect(non_snake_case)]
     #[derive(Deserialize)]
     struct AuthInfo {
         // ClientCertificateData contains PEM-encoded data from a client cert file for TLS. Overrides ClientCertificatePath.
@@ -429,7 +429,7 @@ mod deserialize {
         password: Option<String>,
     }
 
-    #[allow(non_snake_case)]
+    #[expect(non_snake_case)]
     #[derive(Deserialize)]
     struct Datacenter {
         // CertificateAuthorityPath is the path to a cert file for the certificate authority.
@@ -466,7 +466,7 @@ mod deserialize {
         proxyUrl: Option<String>,
     }
 
-    #[allow(non_snake_case)]
+    #[expect(non_snake_case)]
     #[derive(Deserialize)]
     struct Context {
         // DatacenterName is the name of the datacenter for this context.
@@ -476,7 +476,7 @@ mod deserialize {
         authInfoName: String,
     }
 
-    #[allow(non_snake_case)]
+    #[expect(non_snake_case)]
     #[derive(Deserialize, Debug)]
     struct Parameters {
         // DefaultConsistency is the default consistency level used for user queries.

scylla/src/cluster/metadata.rs

@@ -359,7 +359,7 @@ impl std::str::FromStr for ColumnKind {
 
 #[derive(Clone, Debug, PartialEq, Eq)]
 #[non_exhaustive]
-#[allow(clippy::enum_variant_names)]
+#[expect(clippy::enum_variant_names)]
 pub enum Strategy {
     SimpleStrategy {
         replication_factor: usize,
@@ -421,7 +421,7 @@ impl Metadata {
 
 impl MetadataReader {
     /// Creates new MetadataReader, which connects to initially_known_peers in the background
-    #[allow(clippy::too_many_arguments)]
+    #[expect(clippy::too_many_arguments)]
     pub(crate) async fn new(
         initial_known_nodes: Vec<InternalKnownNode>,
         control_connection_repair_requester: broadcast::Sender<()>,
@@ -1664,7 +1664,7 @@ impl ControlConnection {
         'tables_loop: for ((keyspace_name, table_name), table_result) in tables_schema {
             let keyspace_and_table_name = (keyspace_name, table_name);
 
-            #[allow(clippy::type_complexity)]
+            #[expect(clippy::type_complexity)]
             let (columns, partition_key_columns, clustering_key_columns): (
                 HashMap<String, Column>,
                 Vec<(i32, String)>,